-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copy paste not working #242
Comments
Thanks for the heads up. This appears to be because of the recent PR 241. @ghiscoding ? (sorry, I know you're busy with the fixed column branch!)
If this can't be resolved soon, perhaps I need to revert these changes for a while until this is sorted out. It's what I was worrried about with #68, when I looked at it, there was no clear way to fix that issue without breaking other use cases. |
The provided example does not work with Copy and Paste even after reverting (by hand) my code. Was that example ever working with Copy Paste? I mean I went and manually added some data in some of the cells (in the grid) and did a Copy and Pasted in Excel and nothing happens.
in what ways?
I have the latest SlickGrid version in my Angular-Slickgrid and the Copy Paste still works correctly. EDIT <script src="../plugins/slick.cellcopymanager.js"></script>
// code
var copyManager = new Slick.CellCopyManager();` To <script src="../plugins/slick.cellexternalcopymanager.js"></script>
// code
var copyManager = new Slick.CellExternalCopyManager(); |
Sorry, should have given more info. I found the copy paste was broken, and also I was getting the range designators (eg. A3:B6) pasted into cells. That may be a separate issue, but it didn't happen in the reverted version. That said, I'm not sure what was triggering it to occur. |
My PR only has 2 lines of code, it should be easy enough to find which line. But again, if I revert my code manually I don't see it working still EDIT The new argument
The copy cell plugin probably rely on the on cell changed then, does it? |
Might add that to the example documentation. I'm not saying this can be fixed - it might be possible that the two use cases are mutually incompatible. If reverting it would only be a case of 'the devil you know'. We'd need to document that to get the editors working, a patch was necessary. Ugly, but until the time or $$ show up to fix the active cell logic, it may be the only way. Unless, of course, you can fix this. I'm just not 100% sure this is going to be the only thing broken by that change, though. As I said, I spent about two hours looking at #68 originally, and just found it got more complex the more I looked into it. |
Well I need the PR #68 to get Row Selection and Editors to work together, without it, it just doesn't work in my project. However, if you want a quick and dirty way to fix this, I suggest to add a grid option flag that we could use to enable that 4th argument Thinking of a name for the flag, maybe |
bugfix(editor): add a flag to suppress active cell changed on edit #242
I think we can close it now since we addressed the issue in latest PR |
I haven't downloaded the code and tried locally with the latest version yet, but the copy paste examples http://6pac.github.com/SlickGrid/examples/example-spreadsheet.html are not working for me (Chrome 66 & Edge 42).
The text was updated successfully, but these errors were encountered: