From 66c088968a4430f1c69e5b517e402b185fe9a265 Mon Sep 17 00:00:00 2001 From: Simone Silvestri Date: Tue, 5 Mar 2024 13:33:31 -0500 Subject: [PATCH] Remove misleading comment (#3493) * bugfix * remove comment --- src/Fields/field.jl | 9 --------- test/test_distributed_hydrostatic_model.jl | 2 +- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/src/Fields/field.jl b/src/Fields/field.jl index 7e0bb35417..b7aec34012 100644 --- a/src/Fields/field.jl +++ b/src/Fields/field.jl @@ -743,15 +743,6 @@ end function fill_halo_regions!(field::Field, args...; kwargs...) reduced_dims = reduced_dimensions(field) - # To correctly fill the halo regions of fields with non-default indices, we'd have to - # offset indices in the fill halo regions kernels. - # For now we punt and don't support filling halo regions on windowed fields. - # Note that `FieldBoundaryConditions` _can_ filter boundary conditions in - # windowed directions: - # - # filtered_bcs = FieldBoundaryConditions(field.indices, field.boundary_conditions) - # - # which will be useful for implementing halo filling for windowed fields in the future. fill_halo_regions!(field.data, field.boundary_conditions, field.indices, diff --git a/test/test_distributed_hydrostatic_model.jl b/test/test_distributed_hydrostatic_model.jl index 8511a4c8ad..dc2b7b5d6e 100644 --- a/test/test_distributed_hydrostatic_model.jl +++ b/test/test_distributed_hydrostatic_model.jl @@ -79,7 +79,7 @@ Ny = 32 for arch in archs @testset "Testing distributed solid body rotation" begin grid = LatitudeLongitudeGrid(arch, size = (Nx, Ny, 1), - halo = (3, 3, 3), + halo = (4, 4, 4), latitude = (-80, 80), longitude = (-160, 160), z = (-1, 0),