From 5a3496b40980fb1f233a5df7ce6c66ac4a842fe1 Mon Sep 17 00:00:00 2001 From: Fabian Meumertzheim Date: Fri, 21 Apr 2023 12:16:08 +0200 Subject: [PATCH] ci: Merge `bazel build` and `bazel test` On Windows, `bazel test` uses a different `PATH` value than `bazel build`, which results in duplicated build steps. Since `bazel test //...` also builds all targets, the additional `build` step does not provide additional assurances. This may also resolve `failed to delete output files` errors which occur during the test step, likely because the build step leaks open files somewhere. --- .github/workflows/run-all-tests.yml | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/.github/workflows/run-all-tests.yml b/.github/workflows/run-all-tests.yml index 879076354..9728378cc 100644 --- a/.github/workflows/run-all-tests.yml +++ b/.github/workflows/run-all-tests.yml @@ -79,11 +79,8 @@ jobs: run: .github/scripts/echoBuildBuddyConfig.sh ${{ secrets.BUILDBUDDY_API_KEY }} >> $GITHUB_ENV shell: bash - - name: Build - run: bazelisk build ${{env.BUILD_BUDDY_CONFIG}} --java_runtime_version=local_jdk_${{ matrix.jdk }} --disk_cache=${{ matrix.cache }} ${{ matrix.bazel_args }} --build_tag_filters="-no-${{ matrix.arch }}-jdk${{ matrix.jdk }},-no-jdk${{ matrix.jdk }}" //... - - - name: Test - run: bazelisk test ${{env.BUILD_BUDDY_CONFIG}} --java_runtime_version=local_jdk_${{ matrix.jdk }} --disk_cache=${{ matrix.cache }} ${{ matrix.bazel_args }} --test_tag_filters="-no-${{ matrix.arch }}-jdk${{ matrix.jdk }},-no-jdk${{ matrix.jdk }}" //... + - name: Build & Test + run: bazelisk test ${{env.BUILD_BUDDY_CONFIG}} --java_runtime_version=local_jdk_${{ matrix.jdk }} --disk_cache=${{ matrix.cache }} ${{ matrix.bazel_args }} --build_tag_filters="-no-${{ matrix.arch }}-jdk${{ matrix.jdk }},-no-jdk${{ matrix.jdk }}" --test_tag_filters="-no-${{ matrix.arch }}-jdk${{ matrix.jdk }},-no-jdk${{ matrix.jdk }}" //... - name: Copy Bazel log if: always()