From 056275b1a78c04f7aa5e5cfa4911d35ac9af1c5a Mon Sep 17 00:00:00 2001 From: SwatiT17 <129146107+SwatiT17@users.noreply.github.com> Date: Wed, 19 Apr 2023 22:39:23 +0530 Subject: [PATCH] feat: added source_type in output while listing connections list (#803) * feat: added source_type in output while listing connections list ,Unit test updated --- data_validation/cli_tools.py | 4 ++-- tests/unit/test_cli_tools.py | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/data_validation/cli_tools.py b/data_validation/cli_tools.py index 3bc9e40e2..f48e936b9 100644 --- a/data_validation/cli_tools.py +++ b/data_validation/cli_tools.py @@ -988,9 +988,9 @@ def list_connections(): """List all saved connections.""" mgr = state_manager.StateManager() connections = mgr.list_connections() - for conn_name in connections: - logging.info(f"Connection Name: {conn_name}") + source_type = mgr.get_connection_config(conn_name).get("source_type") + logging.info(f"Connection Name: {conn_name} : {source_type}") def get_connection(connection_name): diff --git a/tests/unit/test_cli_tools.py b/tests/unit/test_cli_tools.py index cd1ed03e8..8dba04bb8 100644 --- a/tests/unit/test_cli_tools.py +++ b/tests/unit/test_cli_tools.py @@ -126,7 +126,7 @@ def test_create_and_list_connections(caplog, fs): # List Connection cli_tools.list_connections() - assert "Connection Name: test" in caplog.records[1].msg + assert "Connection Name: test : BigQuery" in caplog.records[1].msg def test_configure_arg_parser_list_and_run_validation_configs():