From 1d923f54b64a30219cb9d33533ac46f9121ecf60 Mon Sep 17 00:00:00 2001 From: Neha Nene Date: Wed, 14 Sep 2022 14:41:39 -0500 Subject: [PATCH] docs: remove snowflake, add row supported DBs (#587) --- README.md | 14 +++++++------- docs/connections.md | 16 ---------------- third_party/ibis/ibis_snowflake/README.md | 16 +++++++++++++++- 3 files changed, 22 insertions(+), 24 deletions(-) diff --git a/README.md b/README.md index ca2aeec6b..3393165bc 100644 --- a/README.md +++ b/README.md @@ -14,7 +14,7 @@ perform this task. DVT supports the following validations: * Column validation (count, sum, avg, min, max, group by) -* Row validation (BQ, Hive, and Teradata only) +* Row validation (BQ, Hive, Teradata, Oracle, SQL Server only) * Schema validation * Custom Query validation * Ad hoc SQL exploration @@ -31,7 +31,6 @@ DVT supports the following connection types: * [Oracle](https://github.com/GoogleCloudPlatform/professional-services-data-validator/blob/develop/docs/connections.md#oracle) * [Postgres](https://github.com/GoogleCloudPlatform/professional-services-data-validator/blob/develop/docs/connections.md#postgres) * [Redshift](https://github.com/GoogleCloudPlatform/professional-services-data-validator/blob/develop/docs/connections.md#redshift) -* [Snowflake](https://github.com/GoogleCloudPlatform/professional-services-data-validator/blob/develop/docs/connections.md#snowflake) * [Spanner](https://github.com/GoogleCloudPlatform/professional-services-data-validator/blob/develop/docs/connections.md#google-spanner) * [Teradata](https://github.com/GoogleCloudPlatform/professional-services-data-validator/blob/develop/docs/connections.md#teradata) @@ -134,9 +133,10 @@ The [Examples](https://github.com/GoogleCloudPlatform/professional-services-data #### Row Validations -(Note: Row hash validation is currently only supported for BigQuery, Teradata, and Imapala/Hive. Struct and array -data types are not currently supported. In addition, please note that SHA256 is not a supported function on teradata -systems. If you wish to perform this comparison on teradata you will need to +(Note: Row hash validation is currently supported for BigQuery, Teradata, Impala/Hive, Oracle, and SQL Server. +Struct and array data types are not currently supported and random row is not yet supported for Oracle or SQL Server. +In addition, please note that SHA256 is not a supported function on Teradata systems. +If you wish to perform this comparison on Teradata you will need to [deploy a UDF to perform the conversion](https://github.com/akuroda/teradata-udf-sha2/blob/master/src/sha256.c).) Below is the command syntax for row validations. In order to run row level @@ -272,7 +272,7 @@ page provides few examples of how this tool can be used to run custom query vali #### Custom Query Row Validations (Note: Row hash validation is currently only supported for BigQuery, Teradata, and -Imapala/Hive. Struct and array data types are not currently supported.) +Impala/Hive. Struct and array data types are not currently supported.) Below is the command syntax for row validations. In order to run row level validations you need to pass `--hash` flag which will specify the fields @@ -535,4 +535,4 @@ cast to NUMERIC. ## Contributing -Contributions are welcome. See the [contributing guide](https://github.com/GoogleCloudPlatform/professional-services-data-validator/blob/develop/CONTRIBUTING.md) for details. +Contributions are welcome. See the [Contributing guide](https://github.com/GoogleCloudPlatform/professional-services-data-validator/blob/develop/CONTRIBUTING.md) for details. diff --git a/docs/connections.md b/docs/connections.md index bda33fa1b..dd416aeb1 100644 --- a/docs/connections.md +++ b/docs/connections.md @@ -46,7 +46,6 @@ The data validation tool supports the following connection types. * [Teradata](#teradata) * [Oracle](#oracle) * [MSSQL](#mssql-server) -* [Snowflake](#snowflake) * [Postgres](#postgres) * [MySQL](#mysql) * [Redshift](#redshift) @@ -172,21 +171,6 @@ Then `pip install pyodbc`. } ``` -## Snowflake -``` -{ - # Configuration Required for All Data Sources - "source_type": "Snowflake", - - # Connection Details - "user": "my-user", - "password": "my-password", - "account": "Snowflake account to connect to" - "database":"my-db" - "schema": "my-schema" -} -``` - ## Postgres ``` { diff --git a/third_party/ibis/ibis_snowflake/README.md b/third_party/ibis/ibis_snowflake/README.md index d84c24202..2dc2e7576 100644 --- a/third_party/ibis/ibis_snowflake/README.md +++ b/third_party/ibis/ibis_snowflake/README.md @@ -32,7 +32,21 @@ The Snowflake client is accessible through the ibis.ibis_snowflake namespace. Th result=tb_name.count().execute() print(result)** -# +# Snowflake DVT connection +``` +{ + # Configuration Required for All Data Sources + "source_type": "Snowflake", + + # Connection Details + "user": "my-user", + "password": "my-password", + "account": "Snowflake account to connect to" + "database":"my-db" + "schema": "my-schema" +} +``` + # **3.Usage** - Schema for the 'students_pointer' table:-