From 367658e043204ce633c1652929bb85ab562921e9 Mon Sep 17 00:00:00 2001 From: "Piyush:)" <47020544+piyushsarraf@users.noreply.github.com> Date: Fri, 3 Nov 2023 20:12:42 +0530 Subject: [PATCH] fix: Adding credentials as parameter for Spanner (#1031) * fix: Adding credentials as parameter for Service Account key * fix: linting fix --------- Co-authored-by: Piyush Sarraf --- third_party/ibis/ibis_cloud_spanner/__init__.py | 5 ++++- third_party/ibis/ibis_cloud_spanner/api.py | 2 ++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/third_party/ibis/ibis_cloud_spanner/__init__.py b/third_party/ibis/ibis_cloud_spanner/__init__.py index e70a4a68d..7a9f7bdd8 100644 --- a/third_party/ibis/ibis_cloud_spanner/__init__.py +++ b/third_party/ibis/ibis_cloud_spanner/__init__.py @@ -38,9 +38,12 @@ def do_connect( instance_id: str, database_id: str = None, project_id: str = None, + credentials=None, ) -> None: - self.spanner_client = spanner.Client(project=project_id) + self.spanner_client = spanner.Client( + project=project_id, credentials=credentials + ) self.instance = self.spanner_client.instance(instance_id) self.database_name = self.instance.database(database_id) ( diff --git a/third_party/ibis/ibis_cloud_spanner/api.py b/third_party/ibis/ibis_cloud_spanner/api.py index 0db1fbdb3..a9a576deb 100644 --- a/third_party/ibis/ibis_cloud_spanner/api.py +++ b/third_party/ibis/ibis_cloud_spanner/api.py @@ -21,6 +21,7 @@ def spanner_connect( instance_id, database_id, project_id=None, + credentials=None, ): """Create a Cloud Spanner Backend for use with Ibis. @@ -38,5 +39,6 @@ def spanner_connect( instance_id=instance_id, database_id=database_id, project_id=project_id, + credentials=credentials, ) return backend