From 8b295cf9746559fa48a448bd44fc6e4094820796 Mon Sep 17 00:00:00 2001 From: AJ Welch <95496513+ajwelch4@users.noreply.github.com> Date: Thu, 3 Mar 2022 10:05:58 -0500 Subject: [PATCH] fix: revert change from #345 that causes filters, threshold and labels to be ignored for column validations (#376) (#379) --- data_validation/__main__.py | 2 +- tests/system/data_sources/test_bigquery.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/data_validation/__main__.py b/data_validation/__main__.py index c93d09322..c3c75e66a 100644 --- a/data_validation/__main__.py +++ b/data_validation/__main__.py @@ -182,7 +182,7 @@ def build_config_managers_from_args(args): # Schema validation will not accept filters, labels, or threshold as flags filter_config, labels, threshold = [], [], 0.0 - if config_type != consts.COLUMN_VALIDATION: + if config_type != consts.SCHEMA_VALIDATION: if args.filters: filter_config = cli_tools.get_filters(args.filters) if args.threshold: diff --git a/tests/system/data_sources/test_bigquery.py b/tests/system/data_sources/test_bigquery.py index 094ff1161..06c9c11c1 100644 --- a/tests/system/data_sources/test_bigquery.py +++ b/tests/system/data_sources/test_bigquery.py @@ -177,7 +177,7 @@ "--config-file", CLI_CONFIG_FILE, ] -EXPECTED_NUM_YAML_LINES = 33 # Expected number of lines for validation config geenrated by CLI_STORE_COLUMN_ARGS +EXPECTED_NUM_YAML_LINES = 36 # Expected number of lines for validation config geenrated by CLI_STORE_COLUMN_ARGS CLI_RUN_CONFIG_ARGS = ["run-config", "--config-file", CLI_CONFIG_FILE] CLI_CONFIGS_RUN_ARGS = ["configs", "run", "--config-file", CLI_CONFIG_FILE]