From b41e6251bb240e2667f25fcb05e45893f0fbe62e Mon Sep 17 00:00:00 2001 From: dhaval-d Date: Tue, 18 May 2021 19:24:25 -0700 Subject: [PATCH] fix: Cli tools bug fix (#253) * added an optional beta flag to be able to provide beta arguments in the future * fix: cli_tools fix for breaking changes * fix: lint * fix: further fixes to resolve integration test issues --- data_validation/cli_tools.py | 27 +++++++++++++++++++-------- 1 file changed, 19 insertions(+), 8 deletions(-) diff --git a/data_validation/cli_tools.py b/data_validation/cli_tools.py index ae795bb29..54781267a 100644 --- a/data_validation/cli_tools.py +++ b/data_validation/cli_tools.py @@ -121,15 +121,24 @@ def configure_arg_parser(): ) parser.add_argument("--verbose", "-v", action="store_true", help="Verbose logging") - parser.add_argument("beta", nargs='?', help="Beta flag to enable beta features for the tool.") - subparsers = parser.add_subparsers(dest="command") - - _configure_run_parser(subparsers) - _configure_run_config_parser(subparsers) - _configure_connection_parser(subparsers) - _configure_find_tables(subparsers) - _configure_raw_query(subparsers) + # beta feature only available in run command + if "beta" in sys.argv: + parser.add_argument( + "beta", + nargs="?", + help="Beta flag to enable beta features for the tool.", + default="", + ) + subparsers = parser.add_subparsers(dest="command") + _configure_run_parser(subparsers) + else: + subparsers = parser.add_subparsers(dest="command") + _configure_run_parser(subparsers) + _configure_run_config_parser(subparsers) + _configure_connection_parser(subparsers) + _configure_find_tables(subparsers) + _configure_raw_query(subparsers) return parser @@ -174,6 +183,8 @@ def _configure_run_config_parser(subparsers): def _configure_run_parser(subparsers): """ Configure arguments to run a data validation.""" + # subparsers = parser.add_subparsers(dest="command") + run_parser = subparsers.add_parser( "run", help="Manually run a validation and optionally store to config" )