From d09c6bc572fe553948eb485afcc783a1ac642340 Mon Sep 17 00:00:00 2001 From: Tim Swast Date: Thu, 23 Jul 2020 10:12:18 -0500 Subject: [PATCH] remove redundant test --- tests/system/result_handlers/test_bigquery.py | 66 ------------------- 1 file changed, 66 deletions(-) diff --git a/tests/system/result_handlers/test_bigquery.py b/tests/system/result_handlers/test_bigquery.py index e98801a15..1f3b6e7a2 100644 --- a/tests/system/result_handlers/test_bigquery.py +++ b/tests/system/result_handlers/test_bigquery.py @@ -139,69 +139,3 @@ def test_execute_with_nan(bigquery_client, bigquery_dataset_id): result = get_dataframe(bigquery_client, table_id) pandas.testing.assert_frame_equal(result, df) bigquery_client.delete_table(table_id) - - -def test_execute_with_none(bigquery_client, bigquery_dataset_id): - table_id = f"{bigquery_dataset_id}.test_execute_with_none" - object_under_test = get_handler(bigquery_client, table_id) - create_bigquery_results_table(bigquery_client, table_id) - end = get_now() - start = end - datetime.timedelta(minutes=1) - df = pandas.DataFrame( - { - "run_id": ["grouped-test"] * 6, - "start_time": [start] * 6, - "end_time": [end] * 6, - "source_table_name": [ - "test_source", - "test_source", - None, - None, - "test_source", - "test_source", - ], - "source_column_name": [ - "source_column", - "source_column", - None, - None, - "source_column", - "source_column", - ], - "target_table_name": [ - "test_target", - "test_target", - "test_target", - "test_target", - None, - None, - ], - "target_column_name": [ - "target_column", - "target_column", - "target_column", - "target_column", - None, - None, - ], - "validation_type": ["GroupedColumn"] * 6, - "aggregation_type": ["count"] * 6, - "validation_name": ["count"] * 6, - "source_agg_value": ["2", "4", None, None, "6", "8"], - "target_agg_value": ["1", "3", "5", "7", "8", "9"], - "group_by_columns": [ - '{"grp_a": "a", "grp_i": "0"}', - '{"grp_a": "a", "grp_i": "1"}', - '{"grp_a": "b", "grp_i": "0"}', - '{"grp_a": "b", "grp_i": "1"}', - '{"grp_a": "c", "grp_i": "0"}', - '{"grp_a": "c", "grp_i": "1"}', - ], - "difference": [-1.0, -1.0, None, None, None, None], - "pct_difference": [-50.0, -25.0, None, None, None, None], - } - ) - object_under_test.execute(None, df) - result = get_dataframe(bigquery_client, table_id) - pandas.testing.assert_frame_equal(result, df) - bigquery_client.delete_table(table_id)