From d3aabca19945564711c256972236e23c05212160 Mon Sep 17 00:00:00 2001 From: Rishab Khawad <118872983+rishabkhawad@users.noreply.github.com> Date: Fri, 31 Mar 2023 20:33:12 +0530 Subject: [PATCH] docs: score-cutoff changed to 1 (#779) * score-cutoff changed * docs: score-cutoff changed --- README.md | 5 ++--- data_validation/__main__.py | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 1e9a7e6c0..af1e4d980 100644 --- a/README.md +++ b/README.md @@ -456,13 +456,12 @@ target. The find-tables tool: - Finally, it prints a JSON list of tables which can be a reference for the validation run config. -Note that our score cutoff default is a 0.8, which was manually tested to be an -accurate value. If no matches occur, reduce this value. +Note that our score cutoff default is 1. If no matches occur, reduce this value as deemed necessary. ``` data-validation find-tables --source-conn source --target-conn target \ --allowed-schemas pso_data_validator \ - --score-cutoff 0.8 + --score-cutoff 1 ``` ### Using Beta CLI Features diff --git a/data_validation/__main__.py b/data_validation/__main__.py index 826512ccc..37e1cd023 100644 --- a/data_validation/__main__.py +++ b/data_validation/__main__.py @@ -374,7 +374,7 @@ def get_table_map(client, allowed_schemas=None): def find_tables_using_string_matching(args): """Return JSON String with matched tables for use in validations.""" - score_cutoff = args.score_cutoff or 0.8 + score_cutoff = args.score_cutoff or 1 mgr = state_manager.StateManager() source_client = clients.get_data_client(mgr.get_connection_config(args.source_conn))