From efce0b838d13441e0a5940f394d5be73cfa52fce Mon Sep 17 00:00:00 2001
From: nj1973 <neil@thirdchimp.net>
Date: Tue, 21 Feb 2023 15:56:31 +0000
Subject: [PATCH] fix: Better detection of Oracle client (#736)

---
 data_validation/config_manager.py | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/data_validation/config_manager.py b/data_validation/config_manager.py
index f7b5ac11b..677a218fa 100644
--- a/data_validation/config_manager.py
+++ b/data_validation/config_manager.py
@@ -715,9 +715,16 @@ def build_config_calculated_fields(
     def _strftime_format(
         self, column_type: Union[dt.Date, dt.Timestamp], client
     ) -> str:
+        def is_oracle_client(client):
+            # When no Oracle client installed clients.OracleClient is not a class
+            try:
+                return isinstance(client, clients.OracleClient)
+            except TypeError:
+                return False
+
         if isinstance(column_type, dt.Timestamp):
             return "%Y-%m-%d %H:%M:%S"
-        if isinstance(client, clients.OracleClient):
+        if is_oracle_client(client):
             # Oracle DATE is a DateTime
             return "%Y-%m-%d %H:%M:%S"
         return "%Y-%m-%d"