{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":5885483,"defaultBranch":"main","name":"Koha","ownerLogin":"Koha-Community","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2012-09-20T11:29:15.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/592086?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1725014756.0","currentOid":""},"activityList":{"items":[{"before":"7e5a2f5a4d7b955be5c16f0367ff89729f8ce831","after":"95ff9ad02d12cf89821c7d24aaf8e36f4a4593a2","ref":"refs/heads/main","pushedAt":"2024-09-05T07:53:38.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 35402: Fix regressions.t\n\nThe audio alert feature is not correctly designed and is problematic.\nIt looks at the class name in the DOM, not when the element with this class name\nwill be displayed to the end user\n\nSo it's not possible to make it work for modals for instance, or if an element\nis built in JS then displayed\n\nThis patch remove the modal code from the code, if there are no waiting\nholds. It is the behaviour that existed prior to the Bootstrap update.\nHowever it is kind of random behaviour, the song that is played when the\nlibrarian open the circ page is different if the user has waiting holds or not.\n\nSigned-off-by: Martin Renvoize \nSigned-off-by: Katrin Fischer ","shortMessageHtmlLink":"Bug 35402: Fix regressions.t"}},{"before":"b34791b001d0c4261234806361d62e3335e52622","after":"7e5a2f5a4d7b955be5c16f0367ff89729f8ce831","ref":"refs/heads/main","pushedAt":"2024-09-05T07:48:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 35838: Fix addition of new slots\n\nThe \"Add\" button didn't add new slots.\n\nSigned-off-by: Katrin Fischer ","shortMessageHtmlLink":"Bug 35838: Fix addition of new slots"}},{"before":"819f0db4cc337313d5345c904245939247966968","after":"1b90c3dc65d3ee2f20b9b3151257290d0e267b56","ref":"refs/heads/24.05.x","pushedAt":"2024-09-03T14:43:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37342: Use get for launching authority popup\n\nThis patch simply switches to a GET as the operation is not cud\n\nTo test:\n 1 - Go to cataloging -> new record\n 2 - If not in basic editor, switch\n 3 - Go to tab 100\n 4 - Enter a name that has no authority in your system: McNotExist, Falsy\n 5 - Click 'Link authorities automatically'\n 6 - subfield 9 should turn red, and have an X and a + button\n 7 - Click the green +\n 8 - Boom\n 9 - Apply patch\n10 - Reload page and repeat (clear cache so js reloads)\n11 - Success! Authority window launches\n\nSigned-off-by: Jake Deery \nSigned-off-by: Emily Lamancusa \nSigned-off-by: Katrin Fischer \n(cherry picked from commit d4f4190f91f567b4432c88e5ff8603e8302b0e4d)\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 37342: Use get for launching authority popup"}},{"before":"e2ce99e3d5c7dd6c1bc060593a9fb7dfb812962c","after":"b34791b001d0c4261234806361d62e3335e52622","ref":"refs/heads/main","pushedAt":"2024-09-03T04:22:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 34440: bookings_lead_period and bookings_trail_period cant be set at categorycode level\n\nFollow Joubu's test plan. It should no longer fail.\n\nError from eval Koha::CirculationRules->set_rules($params) at onboarding.pl was:\nset_rule cannot set 'bookings_trail_period' for a 'categorycode'! at /kohadevbox/koha/installer/onboarding.pl line 301.\n\nSigned-off-by: Martin Renvoize ","shortMessageHtmlLink":"Bug 34440: bookings_lead_period and bookings_trail_period cant be set…"}},{"before":"06f17d9f6a000423e07c9cbc84f2d06198a72567","after":"e2ce99e3d5c7dd6c1bc060593a9fb7dfb812962c","ref":"refs/heads/main","pushedAt":"2024-09-02T15:22:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Revert \"Bug 37493: [DONT PUSH] Test only - Force test fail\"\n\nThis reverts commit 0d69fc60904ec6ad95863977d8cdec35e29047bf.\n\nSigned-off-by: Katrin Fischer ","shortMessageHtmlLink":"Revert \"Bug 37493: [DONT PUSH] Test only - Force test fail\""}},{"before":"bae6560a26d207049b93c289216643fb4ed10919","after":"06f17d9f6a000423e07c9cbc84f2d06198a72567","ref":"refs/heads/main","pushedAt":"2024-09-02T14:36:55.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37794: Fix form that POSTs without an op in Holds to pull\n\nWe intend not to have forms with method=\"post\" without an op variable (so we\ncan check that the op starts with \"cud-\" as part of the CSRF protection), but\nbecause of bug 37728 some were missed.\n\nIn Holds to pull that's the form which lets you change from the default\nstarting and ending date. Switching that to a GET at least lets you refresh\nthe page without getting a browser warning about resending a POST and maybe\nhaving your credit card double-charged.\n\nTest plan:\n1. Without the patch, Circulation - Holds to pull - change the start date to\n something earlier and click Submit\n2. Refresh the page, get a warning about resubmitting data\n3. Apply patch, Circulation - Holds to pull - change the start date to\n something earlier and click Submit\n4. Refresh the page, no warning\n\nSponsored-by: Chetco Community Public Library\n\nSigned-off-by: Jonathan Druart \nSigned-off-by: Katrin Fischer ","shortMessageHtmlLink":"Bug 37794: Fix form that POSTs without an op in Holds to pull"}},{"before":"ed6462818152991bb36a6f578dcf1628d2a85c7a","after":"2e6a7d49a308099efc4148e60a7f897ed6a2988f","ref":"refs/heads/23.11.x","pushedAt":"2024-09-02T12:45:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Revert \"Bug 37059: Fix insert button in notices and slips\"\n\nThis reverts commit 013cda40de12acc3488677139c44d3532cd63f68.","shortMessageHtmlLink":"Revert \"Bug 37059: Fix insert button in notices and slips\""}},{"before":"278df1790d95ead49cb6aab1753af765d584a20c","after":"bae6560a26d207049b93c289216643fb4ed10919","ref":"refs/heads/main","pushedAt":"2024-09-02T10:20:22.000Z","pushType":"push","commitsCount":20,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 33907: Improve translation of title tags: OPAC part 1\n\nThis patch updates a batch of OPAC templates so that title tags can\nbe more easily translated. Some templates have been updated for\nconsistency as well: Harmonizing page title, breaddrumb navigation, and\npage headers.\n\nTo test, apply the patch and confirm that the following pages have\ncorrect title tags:\n\n- Log in to the OPAC by navigating directly to a user page like\n /cgi-bin/koha/opac-user.pl\n- From your user summary page, click \"Charges.\"\n- Check the advanced search page.\n- Search for a bibliographic record and view the details, and then click\n \"MARC view\" and \"ISBD view.\"\n- From this page click \"Save to your lists\" and check the title in the\n popup window.\"\n- Still on a detail page, click \"Add to your cart.\" Open the cart and\n check that page.\n- Go to authority search (must have OpacAuthorities enabled).\n - Perform an authority search which will return results.\n - View the detail page for one of the results, and check the MARC view\n as well.\n- With UseCourseReserves enabled, view the course reserves page, then\n the course reserve detail page.\n- Search for a subscription which has patron notification enabled.\n - View the detail page, then open the \"Subscriptions\" tab. Click \"More\n details.\"\n - On this page you should see a \"Subscribe to email notification\"\n button. Click it to open the subscription page.\n- Check both /cgi-bin/koha/opac-browse.pl and\n /cgi-bin/koha/opac-browser.pl. Whether or not the features are enabled\n you should be able to check the title.\n- Check /cgi-bin/koha/ilsdi.pl as well as one or more views linked to on\n that page.\n- Navigate to a page in the OPAC which doesn't exist to test the error\n page template.\n- Go to Administration -> System preferences and enable the\n OpacMaintenance preference.\n - Go to the OPAC and check the system maintenance page.\n\nSigned-off-by: David Nind \nSigned-off-by: Katrin Fischer ","shortMessageHtmlLink":"Bug 33907: Improve translation of title tags: OPAC part 1"}},{"before":"23d98a4a8a4391256b1c84df86e6d7c4da9705d4","after":"278df1790d95ead49cb6aab1753af765d584a20c","ref":"refs/heads/main","pushedAt":"2024-08-30T14:42:01.000Z","pushType":"push","commitsCount":15,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36085: (QA follow-up) Tidy members/memberentry.pl\n\nSigned-off-by: Katrin Fischer ","shortMessageHtmlLink":"Bug 36085: (QA follow-up) Tidy members/memberentry.pl"}},{"before":"8b55d032931be5a9420ffdd5f14061e324258bf0","after":null,"ref":"refs/heads/dependabot/npm_and_yarn/webpack-5.94.0","pushedAt":"2024-08-30T10:45:56.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"}},{"before":"7342209b34d642935651e7b2275c3ca14656c4b1","after":"23d98a4a8a4391256b1c84df86e6d7c4da9705d4","ref":"refs/heads/main","pushedAt":"2024-08-30T10:45:56.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37177: \"item\" should be \"record\" in list page\n\nThis patch rewords areas of the lists and cart templates so that the\nterm \"record\" is preferred over \"item\" when referring to a bibliographic\nrecord.\n\nTo test, apply the patch and go to Lists in the staff interface.\n\n- If necessary, create a new list.\n- From the list contents view, click \"Add records\" in the toolbar.\n - Submit some valid barcodes and biblionumbers\n - After adding biblionumbers you should see the message \"The record\n ( [number] ) has been added to the list\"\n - After adding barcodes you should see the message \"The record for\n this item ( [barcode] ) has been added to the list\"\n- Click \"Add records\" again\n - Submit some of the same barcodes and biblionumbers\n - You should see these messages:\n - \"The record for this item ( [barcode] ) has not\n been added to the list. Please verify it is not already in the\n list.\"\n - \"The record ( [number] ) has not been added to the\n list. Please verify it is not already in the list.\n- Check the checkbox for one or more titles on your list and click\n \"Remove selected\"\n - You should see the message, \"The record has been removed from the\n list.\"\n- Perform a catalog search and from the results screen, select one or\n more results and add them to the cart.\n - Open the Cart and confirm that the controls at the top of the table\n of titles reads \"Selected records: ...\"\n\nSponsored-by: Athens County Public Libraries\nSigned-off-by: Lucas Gass \n\nSigned-off-by: Marcel de Rooy \nSigned-off-by: Katrin Fischer ","shortMessageHtmlLink":"Bug 37177: \"item\" should be \"record\" in list page"}},{"before":null,"after":"8b55d032931be5a9420ffdd5f14061e324258bf0","ref":"refs/heads/dependabot/npm_and_yarn/webpack-5.94.0","pushedAt":"2024-08-30T02:22:34.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dependabot[bot]","name":null,"path":"/apps/dependabot","primaryAvatarUrl":"https://avatars.githubusercontent.com/in/29110?s=80&v=4"},"commit":{"message":"Bump webpack from 5.74.0 to 5.94.0\n\nBumps [webpack](https://github.com/webpack/webpack) from 5.74.0 to 5.94.0.\n- [Release notes](https://github.com/webpack/webpack/releases)\n- [Commits](https://github.com/webpack/webpack/compare/v5.74.0...v5.94.0)\n\n---\nupdated-dependencies:\n- dependency-name: webpack\n dependency-type: direct:development\n...\n\nSigned-off-by: dependabot[bot] ","shortMessageHtmlLink":"Bump webpack from 5.74.0 to 5.94.0"}},{"before":"8df2d43102531e6cf20ca1e851b9b1e369dfbc4a","after":"819f0db4cc337313d5345c904245939247966968","ref":"refs/heads/24.05.x","pushedAt":"2024-08-29T17:43:12.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37389: (QA follow-up) Tidy\n\nSigned-off-by: Tomas Cohen Arazi \nSigned-off-by: Katrin Fischer \n(cherry picked from commit 897f4f319b7b855cee2056eaa82d28fedce9006d)\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 37389: (QA follow-up) Tidy"}},{"before":"0de82726222c0fc896c6d1d83f86ebb39fdf18da","after":"8df2d43102531e6cf20ca1e851b9b1e369dfbc4a","ref":"refs/heads/24.05.x","pushedAt":"2024-08-29T17:40:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 33453: Change the button class of the record cashup modal to btn-primary\n\nTo test:\n\n1. Go to System Preferences > find and enable \"Use cash registers\"\n2. Go to Administration > \"Cash registers\" and create a new cash register\n3. Go to Tools > \"Transaction history for\" > \"Record cashup\"\n4. Click \"Record cashup\"\n5. Modal with change: \"Confirm\" should be yellow and primary.\n\nSigned-off-by: David Nind \nSigned-off-by: Martin Renvoize \nSigned-off-by: Katrin Fischer \n(cherry picked from commit 3a3d367922233c2422ffc5d216344c717170b64a)\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 33453: Change the button class of the record cashup modal to btn-…"}},{"before":"3c8539bc6b4952922fe80c6e6714efb85b9ed9f1","after":"0de82726222c0fc896c6d1d83f86ebb39fdf18da","ref":"refs/heads/24.05.x","pushedAt":"2024-08-29T17:38:40.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37373: (follow-up) Add id and adjust tests\n\nSigned-off-by: Katrin Fischer \n(cherry picked from commit d5f0191bda908aa071d4207dbf2f30018cb7db53)\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 37373: (follow-up) Add id and adjust tests"}},{"before":"812f268d8a2e2c070ad383e7ea09cd15e0ffc6b3","after":"3c8539bc6b4952922fe80c6e6714efb85b9ed9f1","ref":"refs/heads/24.05.x","pushedAt":"2024-08-29T17:33:17.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37411: Fixed exporting to CSV file\n\nTo test:\n1. Acquistions -> Budgets -> Funds -> Planning, select any option\n2. In the toolbar see Export, and click Submit and see a 500 error\n3. Apply patch, restart_all\n4. Repeat steps 1-2\n5. Notice the 500 error is gone and the CSV is exported properly\n\nSigned-off-by: Roman Dolny \nSigned-off-by: Martin Renvoize \nSigned-off-by: Katrin Fischer \n(cherry picked from commit 94890a1e55735504b2f405c4b82793e3a2e44fc3)\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 37411: Fixed exporting to CSV file"}},{"before":"04b7d7f1ffe464120b26fed5636fae215f4be608","after":"812f268d8a2e2c070ad383e7ea09cd15e0ffc6b3","ref":"refs/heads/24.05.x","pushedAt":"2024-08-29T17:30:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37489: Separate forms for uploading and deleting a patron image\n\nThis patch creats a new form for image deletion that is submitted via the 'Delete' button on the modal.\n\nTo test:\n1) Turon on the 'patronimages' sys pref\n2) Visit a patron page, you should see an image module on the left.\n3) Click on the image to edit it. Upload a new image.\n4) Edit the image again, press delete and confirm the popup.\n5) Note that it will not let you delete because of the required file.\n6) Apply patch\n7) Attempt to delete again, this time it is successful.\n\nSigned-off-by: Roman Dolny \nSigned-off-by: David Cook \nSigned-off-by: Katrin Fischer \n(cherry picked from commit 2263d9f3b0aef977642eaffa38fb5bddae16bc0e)\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 37489: Separate forms for uploading and deleting a patron image"}},{"before":"ee1fb146b2404b15da3aefe28543480b5424d3ea","after":"04b7d7f1ffe464120b26fed5636fae215f4be608","ref":"refs/heads/24.05.x","pushedAt":"2024-08-29T17:28:21.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37288: Allow manual providers to be edited\n\nThere is a bug preventing manually created providers from being edited. This patch fixes that issue and allows providers to be edited if they have been created manually\n\nTest plan:\n1) Create a data provider in the ERM manually using the Create manually option\n2) Click to edit that provider\n3) The form will not load\n4) Apply patch and run yarn build\n5) Hard refresh the browser\n6) The form should now load correctly\n\nSigned-off-by: David Nind \nSigned-off-by: Martin Renvoize \nSigned-off-by: Katrin Fischer \n(cherry picked from commit 8872aa91e35a77951eb60037bc1f709fe093f00a)\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 37288: Allow manual providers to be edited"}},{"before":"b603bd91b363bcd323e4a79c837ac24361614b85","after":"ee1fb146b2404b15da3aefe28543480b5424d3ea","ref":"refs/heads/24.05.x","pushedAt":"2024-08-29T17:26:31.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37419: Schema updates\n\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 37419: Schema updates"}},{"before":"52f928beb013942d13d0fabf420a5ea7d2c29f6c","after":"b603bd91b363bcd323e4a79c837ac24361614b85","ref":"refs/heads/24.05.x","pushedAt":"2024-08-29T17:14:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37093: Searching for reports on Mana should use GET\n\nSearching for reports on Mana currently fails by sending a POST to\nsvc/mana/search without a CSRF token. There's no reason to POST, it's\njust sending a search string.\n\n 1. Enable Mana: Reports - lower right is a blue Knowledgebase box with\n a link to Change your Mana KB settings\n 2. Switch Use Mana KB to Yes, click Save, below that give it a name and\n email, Send to Mana KB\n 3. Reports - Use saved - New report - New SQL from Mana\n 4. Enter any keyword to search, get a 403 forbidden error\n 5. Apply patch, restart_all, Shift+Reload the page to clear cache\n 6. Enter any keyword likely to return results, like select, get results\n\nSigned-off-by: David Nind \nSigned-off-by: Victor Grousset/tuxayo \nSigned-off-by: Katrin Fischer \n(cherry picked from commit f4d248f076ef7368535beead9689acf4ad98d5f3)\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 37093: Searching for reports on Mana should use GET"}},{"before":"54e26935e931ee579c3f651d72a497109dfc8349","after":"52f928beb013942d13d0fabf420a5ea7d2c29f6c","ref":"refs/heads/24.05.x","pushedAt":"2024-08-29T17:13:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37523: CSRF error when modifying an existing patron record\n\nThis patch modifies the patron entry template to avoid a CSRF error when\nclicking the \"Edit existing record\" button after a duplicate patron is\nfound. The operation should be GET and thus can be a link.\n\nTo test, apply the patch and go to Patrons.\n\n- If you aren't using the default testing data you should first locate\n an existing patron record so you can refer to the details.\n- Start the process of creating a new patron record.\n- Use the existing patron's data to fill out the form.\n - With the default data you can use:\n - Surname: Bennett\n - First name: Pamela\n - Date of birth: 09/16/1946\n - Any random new card number\n- When you click \"Save\" you should get a duplicate patron warning:\n \"Duplicate patron record?\"\n - Click \"It is a duplicate. Edit existing record.\"\n - You should be taken to the edit form for the existing patron.\n\nSponsored-by: Athens County Public Libraries\nSigned-off-by: Roman Dolny \nSigned-off-by: Johanna Räisä \nSigned-off-by: Emily Lamancusa \nSigned-off-by: Katrin Fischer \n(cherry picked from commit 2f6226ad695a7092c71ba86d06bd9d7edac8f583)\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 37523: CSRF error when modifying an existing patron record"}},{"before":"528db7e928367b8f1c2c358abb4f685d74a20bf2","after":"54e26935e931ee579c3f651d72a497109dfc8349","ref":"refs/heads/24.05.x","pushedAt":"2024-08-29T17:02:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 35236: Make \"Batch description\" label match corresponding field\n\nTo test:\n 1. Create a new patron.\n 2. Go to Tools -> Patron card creator.\n 3. Create a new patron card batch.\n 4. On the \"Edit patron card batch\" page, click the \"Batch\n description:\" label.\n 5. Observe that the corresponding field is selected.\n\nMentored-by: Catalyst Academy\nSigned-off-by: David Nind \nSigned-off-by: Martin Renvoize \n(cherry picked from commit 558b900895a42ff33fed06f746f677ac9ea3f51c)\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 35236: Make \"Batch description\" label match corresponding <input>…"}},{"before":"10f8db24704139fdd90e73c1670149244b5a6dab","after":"528db7e928367b8f1c2c358abb4f685d74a20bf2","ref":"refs/heads/24.05.x","pushedAt":"2024-08-29T17:01:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36998: Correctly update the 'Amount paid' displayed on the issue refund modal\n\nTo test:\n1) Enable the 'EnablePointOfSale' sys pref (also requires the 'UseCashRegisters' pref)\n2) In the POS module, configure a cash register and also configure some items for purchase with different costs\n3) Make multiple sales\n4) View the transactions table by clicking the 'Cash summary for ...' tab and then clicking on your cash register's name.\n5) Click on the 'Issue refund' button for one of the sales, this should have the correct 'Amount paid'\n6) Close the modal and click issue refund on your other item.\n7) Note the 'Amount paid' is incorrect and lists the value from the previous item\n8) Apply patch\n9) Now when clicking issue refund, it displays the correct 'Amount paid'\n\nSigned-off-by: Barbara Johnson \nSigned-off-by: Martin Renvoize \n(cherry picked from commit 47a3c284734c56e095a5945cdbd40f6e50652496)\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 36998: Correctly update the 'Amount paid' displayed on the issue …"}},{"before":"a963c6bc14253d736ccfa0a3618d5d6e0e0ed955","after":"10f8db24704139fdd90e73c1670149244b5a6dab","ref":"refs/heads/24.05.x","pushedAt":"2024-08-29T17:00:15.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37476: Fix reserved word error on Serials.pm on MySQL 8\n\nThis patch fixes the fact `RANK` become a reserved word in MySQL 8.0.2\n[1]\n\nTo test:\n1. Launch KTD with MySQL 8:\n $ ktd down\n $ DB_IMAGE=mysql:8 ktd up -d\n2. Open the logs\n $ ktd --shell\n k$ tail -f /var/log/koha/kohadev/*.log\n3. Create a serial, receive an issue and try to create a routing list\n4. Click on `+ Add recipients` and look for Henry\n5. Click `Add` and then `Close`\n=> FAIL: Henry not added\n=> FAIL: The logs show an error about wrong SQL syntax\n6. Run:\n k$ prove t/db_dependent/Serials.t\n=> FAIL: Tests explode with the same kind of error!\n6. Apply this patch\n7. Restart plack\n8. Repeat 3 through 6\n=> SUCCESS: Henry added!\n=> SUCCESS: No explosion about the SQL syntax in the logs\n=> SUCCESS: Tests pass!\n9. Sign off :-D\n\n[1] https://dev.mysql.com/doc/refman/8.0/en/keywords.html\n\nSigned-off-by: Emily Lamancusa \nSigned-off-by: Martin Renvoize \n(cherry picked from commit a4b9dcaf61c657a315e0de16e0d68163ece9ed0e)\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 37476: Fix reserved word error on Serials.pm on MySQL 8"}},{"before":"90eef225751d9045f1793c79f494a149e7cf476b","after":"a963c6bc14253d736ccfa0a3618d5d6e0e0ed955","ref":"refs/heads/24.05.x","pushedAt":"2024-08-29T16:57:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 36196: Handling NULL data on ajax call\n\nTest plan:\n\n1) Update some data in your cities table, sample for one send:\n\"UPDATE cities SET city_state=NULL WHERE cityid=\"\n2) Go on \"/cgi-bin/koha/admin/cities.pl\" and wait a entire life :)\n3) Apply this patch\n4) Rebuild your po files if needed\n5) Reload the same page and now you get normally the datatable\n\nSponsored by: BibLibre\nSigned-off-by: Lucas Gass \nSigned-off-by: Martin Renvoize \n(cherry picked from commit e0856d0db648766ba1d65a4f784983a416ac4a35)\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 36196: Handling NULL data on ajax call"}},{"before":"ca663e537725f63e8eecc23a1f34f0143e91d593","after":"90eef225751d9045f1793c79f494a149e7cf476b","ref":"refs/heads/24.05.x","pushedAt":"2024-08-29T16:49:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37303: Update yarn.lock after adding new dependency to packages.json\n\n use ./xt/verify-yarnlock.t test in BZ 37490 to confirm\n\nSigned-off-by: Katrin Fischer \n(cherry picked from commit 8ff9e665e4d275ac601ee5165ab4233a14189f2c)\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 37303: Update yarn.lock after adding new dependency to packages.json"}},{"before":"ca43567e86220d1a5ef645d23b500ef4a6362169","after":"ca663e537725f63e8eecc23a1f34f0143e91d593","ref":"refs/heads/24.05.x","pushedAt":"2024-08-29T16:48:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37303: Replace po2json with a JS version\n\nWhen using __() (ie. Gettext.js) we are seeing the translations that are marked as fuzzy.\nThis is definitely not the expected behaviour.\n\nIt happens because (our version of) po2json are old and no longer maintained,\nand just embed them.\n\nIt seems that the bin we have has been upgraded to a JS version\n(different authors).\n\nTest plan:\n(replace LANG with your language code)\n0. Do not apply this patch\nEdit misc/translator/po/LANG-messages-js.po\nMark a string as fuzzy\nEdit ./intranet-main.tt and add the following lines inside $(document).ready\n console.log(_(\"Your string\"));\n console.log(__(\"Your string\"));\nReplace \"Your string\" with the string you are actually testing.\n\nUpdate the templates: `koha-translate --update LANG --dev kohadev && restart_all`\n\nGo to the Koha home page, open the console.\n\n=> Notice that the second log in the console is displaying the fuzzy string.\n\n1. Apply this patch\nInstall the new version of po2json using `yarn install`\nRepeat the previous steps.\n\n=> With this patch applied both logs show the English version of the\nstring.\n\nRemove fuzzy, update the templates and try again.\n\nSigned-off-by: Julian Maurice \nSigned-off-by: Victor Grousset/tuxayo \nSigned-off-by: Martin Renvoize \n(cherry picked from commit 4eb981635453871fa2a33396391f3f75a6baa8b1)\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 37303: Replace po2json with a JS version"}},{"before":"2dbf64d7ad280aabd9eba6f0c4f0a5e40a2f0a83","after":"ca43567e86220d1a5ef645d23b500ef4a6362169","ref":"refs/heads/24.05.x","pushedAt":"2024-08-29T16:46:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37351: Rework checkbox JS to work with paginating dataTable\n\nTo Test:\n\n1. Log in to staff client\n2. Place items on items for borrowers\n 2-1 Place enough holds as noted above\n 2-2 Trap holds for borrowers\n3. Open Circulation->Holds Awaiting Pickup (circ/waitingreserves.pl)\n4. Click a checkbox for one or mroe holds\n Note->The 'Cancel selected (0)' button changes to 'Cancel\n\tselected (1)', etc.\n5. Cancel selected Holds using the (Cancel selected (#) button)\n6. Confirm Cancellation\n7. Wait for background processes to complete, then verify holds are cancelled.\n8. Return to Open Circulation->Holds Awaiting Pickup (circ/waitingreserves.pl)\n9. Ensure button shows \"Cancel selected (0)\"\n10. Click \"Next >\" to navigate to page 2 of holds\n11. Click a checkbox for one or more holds\n Note->The 'Cancel selected (0)' button DOES NOT increase as boxes\n\tare selected.\n12. Cancel selected Holds using the (Cancel selected (#) button)\n13. Confirm Cancellation\n14. Wait for background processes to complete, then verify holds are cancelled.\n Note-> Holds were not cancelled\n\n15. APPLY PATCH\n16. Try step 9-14 again. This time the 'Cancel selected (0)' button should update even when you paginate.\n17. Make sure you try all the tables, Holds waiting, Holds waiting over X, Holds with cancellation requests.\n\nSigned-off-by: Roman Dolny \nSigned-off-by: Martin Renvoize \n(cherry picked from commit bbd1fa0bfa2604e60eb38072569d7af5ec6808d8)\nSigned-off-by: Lucas Gass ","shortMessageHtmlLink":"Bug 37351: Rework checkbox JS to work with paginating dataTable"}},{"before":"ddcf2b9b70763c2b5ab2e3477ecbff0cffee70fa","after":"7342209b34d642935651e7b2275c3ca14656c4b1","ref":"refs/heads/main","pushedAt":"2024-08-29T16:16:38.000Z","pushType":"push","commitsCount":10,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37048: Use template wrapper for self checkout page\n\nThis patch updates the OPAC's self checkout page template to use\nWRAPPERs for the Bootstrap tabs markup.\n\nTo test, apply the patch and enable the \"WebBasedSelfCheck\" system\npreference if necessary.\n\n- Navigate to the self checkout page\n (http://127.0.0.1:8080/cgi-bin/koha/sco/sco-main.pl)\n - Start checking out to a patron\n - You should see three tabs, \"Checkouts\", \"Holds\", and \"Charges.\"\n The tabs should look correct and work correctly.\n\nSponsored-By: Athens County Public Libraries\nSigned-off-by: David Nind \nSigned-off-by: Lucas Gass \nSigned-off-by: Katrin Fischer ","shortMessageHtmlLink":"Bug 37048: Use template wrapper for self checkout page"}},{"before":"4f524635516325bfe6b56ddf96476c03086956b6","after":"ddcf2b9b70763c2b5ab2e3477ecbff0cffee70fa","ref":"refs/heads/main","pushedAt":"2024-08-29T15:24:21.000Z","pushType":"push","commitsCount":12,"pusher":{"login":"joubu","name":null,"path":"/joubu","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/671757?s=80&v=4"},"commit":{"message":"Bug 37755: Fix batch del record (adding the missing _panel suffix)\n\nSigned-off-by: Jonathan Druart \nSigned-off-by: Katrin Fischer ","shortMessageHtmlLink":"Bug 37755: Fix batch del record (adding the missing _panel suffix)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAErYr7hwA","startCursor":null,"endCursor":null}},"title":"Activity · Koha-Community/Koha"}