[Bug]: "MS365 - Black" theme is unreadable

[Smurf-IV]

Using today's alpha, and the test app, the MS365 - Black theme is unreadable in both active and non focused states:

And Active:

[Wagnerp]

Hi @Smurf-IV

This is the value you want to play around with...

   SystemColors.Control, // InputControlBackDisabled

[Smurf-IV]

This is the value you want to play around with...

   SystemColors.Control, // InputControlBackDisabled

What has this to do with the theme colours ?

[Wagnerp]

This is the value you want to play around with...

   SystemColors.Control, // InputControlBackDisabled

What has this to do with the theme colours ?

It's within the colours array of the theme, and controls the 'disabled' bg colour

[Smurf-IV]

Noting should be using SystemColors.Control as different people have different backgrounds etc (i.e. Dark OS themes have nothing to do with Dark Krypton themes)
And if the user has a light OS theme, then those system colours are going to be "Very wrong" for use with Dark Krypton themes.

[Wagnerp]

Noting should be using SystemColors.Control as different people have different backgrounds etc (i.e. Dark OS themes have nothing to do with Dark Krypton themes) And if the user has a light OS theme, then those system colours are going to be "Very wrong" for use with Dark Krypton themes.

I think this has existed in previous themes since 4.x

then those system colours are going to be "Very wrong" for use with Dark Krypton themes.

No, as these were changed in PR #1587 to be colour appropriate

[Wagnerp]

@Smurf-IV

I think this should be more of a Bug/FR, since it's a legacy thing that needs updating to match modern design principals, i.e. dark/light modes introduced with Win 10.

Thoughts @giduac?

[giduac]

@Wagnerp & @Smurf-IV

There are a lot of those tickets.

@Wagnerp , can you make a concise overview of things you run into when fine tuning themes and maybe also defining the main color setup of themes.

So we can look into this together and what can be done about it.

[Wagnerp]

@giduac

can you make a concise overview of things you run into when fine tuning themes and maybe also defining the main color setup of themes.

Will post it in the discussions

[giduac]

Probably open a discussion where we can dig down a little deeper into this...

[Wagnerp]

Probably open a discussion where we can dig down a little deeper into this...

Hi @Smurf-IV & @giduac

Please see #1608 for how theme colours work

[Wagnerp]

Hi @Smurf-IV & @giduac

I now know where to fix this. Do you want me to apply the same fixes for the O2k7/10 themes as well, or leave them be?

[Smurf-IV]

My vote is to: Fixing themes is the focus for v90

[Wagnerp]

Fixed, PR incoming