From 19a450995a200aa326fe25a2c84ad22b23c00718 Mon Sep 17 00:00:00 2001 From: Kevin Le Seigle Date: Tue, 21 May 2024 15:55:57 +0200 Subject: [PATCH] fix: react ui theme spacing for Button component --- .changeset/old-carrots-complain.md | 6 ++++++ .../src/renderer/components/ButtonV3.tsx | 2 -- .../src/renderer/screens/market/index.tsx | 2 -- libs/ui/packages/react/src/components/cta/Button/index.tsx | 2 +- 4 files changed, 7 insertions(+), 5 deletions(-) create mode 100644 .changeset/old-carrots-complain.md diff --git a/.changeset/old-carrots-complain.md b/.changeset/old-carrots-complain.md new file mode 100644 index 00000000000..a0fca02e9b2 --- /dev/null +++ b/.changeset/old-carrots-complain.md @@ -0,0 +1,6 @@ +--- +"ledger-live-desktop": minor +"@ledgerhq/react-ui": minor +--- + +Fix border-radius in our react DS for the Button diff --git a/apps/ledger-live-desktop/src/renderer/components/ButtonV3.tsx b/apps/ledger-live-desktop/src/renderer/components/ButtonV3.tsx index 35347ed9d87..9147b32c427 100644 --- a/apps/ledger-live-desktop/src/renderer/components/ButtonV3.tsx +++ b/apps/ledger-live-desktop/src/renderer/components/ButtonV3.tsx @@ -5,8 +5,6 @@ import { useTrack } from "~/renderer/analytics/segment"; import styled from "styled-components"; export const Base = styled(BaseButton)<{ big?: boolean }>` - border-radius: 44px; - font-size: ${p => (p.big ? "14px" : "12px")}; height: 40px; line-height: 40px; diff --git a/apps/ledger-live-desktop/src/renderer/screens/market/index.tsx b/apps/ledger-live-desktop/src/renderer/screens/market/index.tsx index 36f6c1ab955..7baf9932251 100644 --- a/apps/ledger-live-desktop/src/renderer/screens/market/index.tsx +++ b/apps/ledger-live-desktop/src/renderer/screens/market/index.tsx @@ -24,8 +24,6 @@ const SearchContainer = styled(Flex).attrs({ flexShrink: "1" })` `; export const Button = styled(BaseButton)<{ big?: boolean }>` - border-radius: 44px; - ${p => p.Icon ? ` diff --git a/libs/ui/packages/react/src/components/cta/Button/index.tsx b/libs/ui/packages/react/src/components/cta/Button/index.tsx index c9b4ca73693..4e679a889f2 100644 --- a/libs/ui/packages/react/src/components/cta/Button/index.tsx +++ b/libs/ui/packages/react/src/components/cta/Button/index.tsx @@ -162,7 +162,7 @@ export const Base = baseStyled.button.attrs((p: BaseProps) => ({ }))` background-color: transparent; border-color: transparent; - border-radius: ${p => p.theme.space[13]}px; + border-radius: 44px; border-style: solid; border-width: ${p => (p.outline || p.variant === "shade" ? 1 : 0)}px; font-weight: 600;