Develop format and rtf functions for exposure duration anaylsis #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ummary()`, and add functions for exposure duration analysis.
There was a problem hiding this comment.
There are lots of work! Thank you, @fukuhiro2023! I only have 2 very minor comments.
| @@ -34,9 +34,9 @@ | |||
| #' meta <- meta_sl_example() | |||
| #' | |||
There was a problem hiding this comment.
Is it a good idea if we add a comment explaining what the table mata |> prepare_sl_summary(...) |> formate_sl_summary(...) is for? I guess it is a baseline character table. If so, is it equivalent to the one from mata |> prepare_base_char(...) |> formate_base_char(...). If so, shall we say something here?
| #' | ||
| #' @return RTF file and source dataset for baseline characteristic table. | ||
| #' | ||
| #' @export |
There was a problem hiding this comment.
It looks like the functions prepare_sl_summary() and format_sl_summary are 2 helper functions. I am wondering if we should un-export them...
Looping @wangben718 for a third opinion.
wangben718
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
format_base_char()andrtf_base_char()toformat_sl_summary()andrtf_sl_summary()as the base function for each type of table.format_exp_duration()andrtf_exp_duration()for exposure duration analysis.format_base_char()andrtf_base_char()based onformat_sl_summary()andrtf_sl_summary().