Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all styling with Tailwind #1725

Open
kylemh opened this issue Sep 10, 2023 · 14 comments
Open

Replace all styling with Tailwind #1725

kylemh opened this issue Sep 10, 2023 · 14 comments

Comments

@kylemh
Copy link
Member

kylemh commented Sep 10, 2023

Blocked by #1724

@kylemh kylemh added Status: Blocked At this moment, the completion of this ticket is impossible Type: Developer Experience / Refactoring labels Sep 10, 2023
@kylemh kylemh self-assigned this Sep 10, 2023
@kylemh kylemh removed the Status: Blocked At this moment, the completion of this ticket is impossible label Sep 17, 2023
@kylemh
Copy link
Member Author

kylemh commented Sep 17, 2023

@subhajit20 You could gradually work on this one! One component and/or one page per PR. It's nice because you won't feel like there's a mountain of work. Just whatever you feel comfortable contributing.

@subhajit20
Copy link
Contributor

@kylemh Sure, Can you assign this to me?

@kylemh kylemh assigned subhajit20 and unassigned kylemh Sep 17, 2023
@subhajit20
Copy link
Contributor

@kylemh when I push changes this error is comming
Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17. Learn more: https://reactjs.org/link/switch-to-createroot

Will I change ReactDom.render to create room for all the test files?

@kylemh
Copy link
Member Author

kylemh commented Sep 18, 2023

This is a Next.js application. ReactDOM.render is not used in this repository. Perhaps try re-installing dependencies? Hopefully you've gone through the README instructions!

@subhajit20
Copy link
Contributor

This is a Next.js application. ReactDOM.render is not used in this repository. Perhaps try re-installing dependencies? Hopefully you've gone through the README instructions!

Sorry I have fixed that

@akash0708
Copy link
Contributor

Hello @kylemh is the issue still open? I can help in converting the CSS of the footer to Tailwind. Since this is a big issue I hope it wouldn't be a problem with @subhajit20 if I join.

@kylemh
Copy link
Member Author

kylemh commented Oct 22, 2023

I don't think it'd be a problem! Just steer clear of the work being done in #1746 obviously

@akash0708
Copy link
Contributor

Yes, I will make sure I do that. Should I start working on this? Can you assign me?

@kylemh
Copy link
Member Author

kylemh commented Oct 23, 2023

I can only assign one person to an issue on GitHub. Feel free to work on it regardless. Maybe post here what components you are working on for visibility.

@subhajit20
Copy link
Contributor

subhajit20 commented Nov 16, 2023

hey @kylemh I am not able to make another pr, the create new pr popup is not coming on the pull request page .

@subhajit20
Copy link
Contributor

subhajit20 commented Nov 16, 2023

@kylemh
Copy link
Member Author

kylemh commented Dec 17, 2023

@subhajit20 please note the changes I made here:
https://github.com/OperationCode/front-end/compare/main..ee6c78cfe6ef2bdb5a67a34857e0ccb7372ac9c7

  • I changed some theme names and values.
  • I installed twmerge (please read the docs and make sure that components using the className prop leverage the function that is exported from this package in the manner that I used in these changes).
  • I fixed visual bug in ImageCard (while converting it to Tailwind)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants