From 54f2f6ed1dbedef11807c6c96f2a7ef67f48abce Mon Sep 17 00:00:00 2001 From: Ben Lesh Date: Mon, 20 Nov 2023 15:14:00 -0600 Subject: [PATCH] feat(WebSocketSubject): no longer extends `Subject`. BREAKING CHANGE: `WebSocketSubject` is no longer `instanceof Subject`. Check for `instanceof WebSocketSubject` instead. --- packages/rxjs/src/internal/observable/dom/WebSocketSubject.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/rxjs/src/internal/observable/dom/WebSocketSubject.ts b/packages/rxjs/src/internal/observable/dom/WebSocketSubject.ts index 26e9291f87..956e0884fe 100644 --- a/packages/rxjs/src/internal/observable/dom/WebSocketSubject.ts +++ b/packages/rxjs/src/internal/observable/dom/WebSocketSubject.ts @@ -150,7 +150,7 @@ const WEBSOCKETSUBJECT_INVALID_ERROR_OBJECT = export type WebSocketMessage = string | ArrayBuffer | Blob | ArrayBufferView; -export class WebSocketSubject extends Subject { +export class WebSocketSubject extends Observable { private _config!: WebSocketSubjectConfig; private _output: Subject; @@ -365,6 +365,5 @@ export class WebSocketSubject extends Subject { _socket.close(); } this._resetState(); - super.unsubscribe(); } }