From 8b86e41b097285015e2c1694607e8e582ade79d8 Mon Sep 17 00:00:00 2001
From: Daniel Lockyer <hi@daniellockyer.com>
Date: Fri, 29 Dec 2023 11:15:27 +0100
Subject: [PATCH] Fixed uploading release assets on Windows

- I foolishly used a bash env var format but Windows uses Powershell
- simplest here is just to remove the env var and pass it in directly
---
 .github/workflows/ci.yml | 8 ++------
 package.json             | 2 +-
 2 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index d53eca98..aec45d18 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -106,10 +106,8 @@ jobs:
           retention-days: 7
 
       - name: Upload binaries to GitHub Release
-        run: yarn upload
+        run: yarn upload --upload-all ${{ github.token }}
         if: matrix.node == 18 && startsWith(github.ref, 'refs/tags/')
-        env:
-          GITHUB_TOKEN: ${{ github.token }}
 
   build-qemu:
     runs-on: ubuntu-latest
@@ -162,7 +160,5 @@ jobs:
           retention-days: 7
 
       - name: Upload binaries to GitHub Release
-        run: yarn install --ignore-scripts && yarn upload
+        run: yarn install --ignore-scripts && yarn upload --upload-all ${{ github.token }}
         if: matrix.node == 18 && startsWith(github.ref, 'refs/tags/')
-        env:
-          GITHUB_TOKEN: ${{ github.token }}
diff --git a/package.json b/package.json
index 81f145b3..f696dd06 100644
--- a/package.json
+++ b/package.json
@@ -69,7 +69,7 @@
     "install": "prebuild-install -r napi || node-gyp rebuild",
     "prebuild": "prebuild --runtime napi --all --verbose",
     "rebuild": "node-gyp rebuild",
-    "upload": "prebuild --verbose --prerelease --upload-all ${GITHUB_TOKEN}",
+    "upload": "prebuild --verbose --prerelease",
     "test": "node test/support/createdb.js && mocha -R spec --timeout 480000"
   },
   "license": "BSD-3-Clause",