Add endpoint to allow pulling log files from the web_interface #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piterden
reviewed
Oct 3, 2020
Comment on lines
+1071
to
+1088
| var authHeader = req.get("Authorization") | ||
| var authToken | ||
| if (authHeader) { | ||
| if (authHeader.indexOf(" ") == -1) { | ||
| authToken = authHeader | ||
| } else { | ||
| authHeader = authHeader.split(" ") | ||
| authToken = authHeader[1] | ||
| } | ||
| } else { | ||
| res.set("Authorization", "Basic base64_auth_token") | ||
| return res | ||
| .type("txt") | ||
| .status(401) | ||
| .send( | ||
| 'Access denied: invalid Authorization Header format. Correct format: "Authorization: Basic base64_auth_token"' | ||
| ) | ||
| } |
There was a problem hiding this comment.
I absolutely sure that this part can be carried out from each route, avoiding terrible code repetition!!!
There was a problem hiding this comment.
Yes that is true. We will add that to the list of things to address.
Piterden
reviewed
Oct 5, 2020
| try { | ||
| var logAndOutputFiles = [] | ||
| const tarFile = 'LogAndOutputFiles.tar' | ||
| const userAttachments = process.cwd() + "/attachments" |
There was a problem hiding this comment.
This will not work at Windows OS. You should use path object to join paths.
Piterden
reviewed
Oct 5, 2020
| @@ -1113,4 +1209,14 @@ function isJson(str) { | |||
| return str | |||
| } | |||
|
|
|||
| function checkForLog(fileName, pathName, destDir, list) { | |||
| if (!fs.existsSync(pathName)) { | |||
| console.log('get logs: cannot find:' + pathName) | |||
There was a problem hiding this comment.
It is much better to use return after this line and avoid using else.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.