Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tesla Historic Stock Price Analysis #849

Merged
merged 5 commits into from
Jul 14, 2024
Merged

Conversation

abckhush
Copy link
Contributor

Pull Request for DL-Simplified 💡

Issue Title : Tesla Historic Stock Price Analysis

  • Info about the related issue (Aim of the project) :
  • Name: Khushi Kalra
  • GitHub ID: https://www.github.com/abckhush
  • Email ID: [email protected]
  • Idenitfy yourself: (Mention in which program you are contributing in. Eg. For a JWOC 2022 participant it's, JWOC Participant) GSSoC'24 Contributor

Closes: #845

Describe the add-ons or changes you've made 📃

I've implemented the models:

  1. GRU (Gated Recurrent Unit)
  2. BiGRU (Bidirectional Gated Recurrent Unit)

Type of change ☑️

What sort of change have you made:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, local variables)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? ⚙️

The models have been trained and evaluated on the dataset, with performance metrics recorded for comparison.

  1. GRU Model
  • R2 Score: 0.929
  • RMSE: 0.0004
  1. BiGRU Model
  • R2 Score: 0.971
  • RMSE: 0.0005

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

Copy link

Our team will soon review your PR. Thanks @abckhush :)

@abhisheks008 abhisheks008 changed the title added Tesla Historic Stock Price Analysis Tesla Historic Stock Price Analysis Jul 14, 2024
Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abckhush can you add the plots (EDA results) inside the README file under Data Visualization tag? It'll be better for others to visualize the dataset.

@abhisheks008 abhisheks008 added Status: Requested Changes Changes requested. gssoc Girlscript Summer of Code 2024 labels Jul 14, 2024
@abckhush
Copy link
Contributor Author

@abhisheks008 done. Kindly check.

Copy link
Owner

@abhisheks008 abhisheks008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @abckhush looks good to me. Approved ✅

@abhisheks008 abhisheks008 added Status: Approved Approved PR by the PA. level2 Level 2 for GSSOC and removed Status: Requested Changes Changes requested. labels Jul 14, 2024
@abhisheks008 abhisheks008 merged commit ad1175e into abhisheks008:main Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girlscript Summer of Code 2024 level2 Level 2 for GSSOC Points Updated Status: Approved Approved PR by the PA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Project Addition]: Tesla Historic Stock Price Analysis
2 participants