From 4198f5b5dc2d06941e38b294923d8213c347c319 Mon Sep 17 00:00:00 2001 From: Kristiyan Kostadinov Date: Sun, 20 Feb 2022 20:32:01 +0100 Subject: [PATCH] fix(material-experimental/mdc-dialog): align change detection with non-MDC version (#24451) The non-MDC dialog container uses `Default` change detection while the MDC one uses `OnPush` which causes issues for users trying to migrate. These changes align the behavior to make things easier. (cherry picked from commit 4c0a4603d93d77646c135b979cce76a1f80b2246) --- src/material-experimental/mdc-dialog/dialog-container.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/material-experimental/mdc-dialog/dialog-container.ts b/src/material-experimental/mdc-dialog/dialog-container.ts index f94ef3dac2c7..fad5c1775c54 100644 --- a/src/material-experimental/mdc-dialog/dialog-container.ts +++ b/src/material-experimental/mdc-dialog/dialog-container.ts @@ -32,7 +32,9 @@ import {cssClasses, numbers} from '@material/dialog'; templateUrl: 'dialog-container.html', styleUrls: ['dialog.css'], encapsulation: ViewEncapsulation.None, - changeDetection: ChangeDetectionStrategy.OnPush, + // Disabled for consistency with the non-MDC dialog container. + // tslint:disable-next-line:validate-decorators + changeDetection: ChangeDetectionStrategy.Default, host: { 'class': 'mat-mdc-dialog-container mdc-dialog', 'tabindex': '-1',