Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make runtime-testsuite tests run in parallel #3423

Closed
wants to merge 78 commits into from

Conversation

jcking
Copy link
Collaborator

@jcking jcking commented Dec 20, 2021

No description provided.

jcking and others added 30 commits November 1, 2021 06:28
[C++] Upstream various performance, build, and best practice fixes
Fix quotation mark error
Update case-insensitive-lexing.md
…e direct file path to runtime files

It has significantly improved performance
…y test run

It has significantly improved performance
[C++] Cleanup ATNDeserializer interface
…rmance

C#, JavaScript, Go runtime tests performance improvements
[C++] Bump minimum required version to C++17
[Java] Fix complaints from ErrorProne static analysis
runtime-testsuite/pom.xml Outdated Show resolved Hide resolved
@KvanTTT
Copy link
Member

KvanTTT commented Dec 20, 2021

Related issue: #3370

@jcking jcking force-pushed the parallel-tests branch 8 times, most recently from cc65c15 to caece10 Compare December 20, 2021 21:33
@@ -3,7 +3,10 @@ version: 2.1
jobs:
test_tool_and_runtime_java:
docker:
- image: cimg/openjdk:8.0
- image: cimg/openjdk:11.0.13
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend waiting for the merging of that request #3407 There are some troubles with JDK updating.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost ready.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we are going to be only java 8 for this next release because there's no way to use java 11 and generate java 8 class files apparently, at least reliably.

@jcking
Copy link
Collaborator Author

jcking commented Dec 20, 2021

This is something to do with the circleci environment compared to running locally. I'll look into this a different time.

@parrt
Copy link
Member

parrt commented Dec 23, 2021

Just a heads up that I think there's an issue with Swift + parallel tests + (possibly) M1 mac. I see an explosion of swift-frontend processes and it brings the machine to its knees; can't even bring a shell up to kill things.

@KvanTTT
Copy link
Member

KvanTTT commented Dec 23, 2021

Have you tried to restrict thread count (2, 4)? It might help.

@parrt
Copy link
Member

parrt commented Dec 23, 2021

yep, I tried threadCount=4 and it's still screwed my machine despite having 8 core.

@KvanTTT
Copy link
Member

KvanTTT commented Dec 23, 2021

And single thread mode works fine?

@parrt
Copy link
Member

parrt commented Dec 23, 2021

Yes, there is no problem running Single threaded mode Swift tests. I just completed one run and I'm now testing your release build version. It does seem faster by the way using release mode

@parrt
Copy link
Member

parrt commented Dec 30, 2021

@jcking i think we can close this draft; i banged my head on a big CI clean up yesterday: #3445 Merging shortly.

@ericvergnaud
Copy link
Contributor

ericvergnaud commented Dec 30, 2021 via email

@KvanTTT
Copy link
Member

KvanTTT commented Dec 30, 2021

I plan to look into it at some point, it would help to have more recent java for the tool and test rig, whilst sticking to Java 8 for the runtime.

It's hardly possible. I've sent Terrence the following StackOverflow answer: https://stackoverflow.com/a/56064482/1046374 Java 8 and Java 11 have different JVM runtime API.

@parrt
Copy link
Member

parrt commented Dec 30, 2021

oh right. forgot about that. We'll have to move in lock step src/trg :(

@ericvergnaud
Copy link
Contributor

I plan to look into it at some point, it would help to have more recent java for the tool and test rig, whilst sticking to Java 8 for the runtime.

It's hardly possible. I've sent Terrence the following StackOverflow answer: https://stackoverflow.com/a/56064482/1046374 Java 8 and Java 11 have different JVM runtime API.

That SO thread is about a different challenge i.e. running Java 11 source code on Java 8 JVM.
What I'm proposing is run the tool using Java 11 (or 16), but keep the runtime in Java 8.

@parrt
Copy link
Member

parrt commented Dec 30, 2021

We'd have to prevent java 11 code / lib calls in runtime somehow but I'm for it if we can.

@KvanTTT
Copy link
Member

KvanTTT commented Jun 27, 2022

I suggest closing since it completely has been fixed by #3752

@parrt parrt closed this Jun 27, 2022
@parrt
Copy link
Member

parrt commented Jun 27, 2022

Yep, Thanks for the work on this @jcking. Looks like the new PR covers this well... Please let me know if there's something else in this PR that we should carve out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants