Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Test plugin that verifies platform and version #178

Draft
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

janpio
Copy link
Member

@janpio janpio commented Jun 29, 2019

closes #176

@project-bot project-bot bot added this to 🐣 New PR / Untriaged in Apache Cordova: Tooling Pull Requests Jun 29, 2019
@janpio janpio changed the title feat: Plugin that verifies platform and version feat: Test plugin that verifies platform and version Jun 29, 2019
@janpio
Copy link
Member Author

janpio commented Jun 29, 2019

Currently blocked by #179

@janpio
Copy link
Member Author

janpio commented Jun 29, 2019

PoC works:

  • platform and version works everywhere.
  • model values are too random for now (Edge => MicrosoftEdge, most iOS and Android Emulators)
  • local/ios has target which is not handled right now.

TODO:

  • Workaround or disable model
  • Add correct value to test description
  • fix ✗ .version should be correct - Expected '9' to contain '9.0'.
  • handle target so local/ios build is recognized broken! (12 instead of 10 as requested)

Attention: #179 still falsifies the results too positive!

@janpio janpio force-pushed the janpio-platform_verification branch from f49a12e to f420f5a Compare July 2, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Test if builds are run on correct devices
1 participant