Return valid MAC address in any situation

apache · May 11, 2023 · 12fe117 · 12fe117
1 parent 9f9434b
commit 12fe117
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/csharp/rocketmq-client-csharp/Utilities.cs b/csharp/rocketmq-client-csharp/Utilities.cs
@@ -32,6 +32,9 @@ public static class Utilities
         private static long _instanceSequence = 0;
         private static readonly int ProcessId = Process.GetCurrentProcess().Id;
         private static readonly string HostName = System.Net.Dns.GetHostName();
+        private static readonly byte[] RandomMacAddressBytes =
+            Enumerable.Range(0, 6).Select(_ => (byte)new Random().Next(256)).ToArray();
+
         public const int MasterBrokerId = 0;
 
         public static int GetPositiveMod(int k, int n)
@@ -42,9 +45,16 @@ public static int GetPositiveMod(int k, int n)
 
         public static byte[] GetMacAddress()
         {
-            return NetworkInterface.GetAllNetworkInterfaces().FirstOrDefault(nic =>
-                nic.OperationalStatus == OperationalStatus.Up &&
-                nic.NetworkInterfaceType != NetworkInterfaceType.Loopback)?.GetPhysicalAddress().GetAddressBytes();
+            var nic = NetworkInterface.GetAllNetworkInterfaces().FirstOrDefault(
+                          x => x.OperationalStatus == OperationalStatus.Up &&
+                               x.NetworkInterfaceType != NetworkInterfaceType.Loopback) ??
+                      NetworkInterface.GetAllNetworkInterfaces().FirstOrDefault(
+                          x => x.OperationalStatus == OperationalStatus.Unknown &&
+                               x.NetworkInterfaceType != NetworkInterfaceType.Loopback) ??
+                      NetworkInterface.GetAllNetworkInterfaces().FirstOrDefault(
+                          x => x.NetworkInterfaceType != NetworkInterfaceType.Loopback);
+
+            return nic != null ? nic.GetPhysicalAddress().GetAddressBytes() : RandomMacAddressBytes;
         }
 
         public static int GetProcessId()

diff --git a/csharp/tests/UtilitiesTest.cs b/csharp/tests/UtilitiesTest.cs
@@ -46,5 +46,12 @@ public void TestComputeSha1Hash()
             var bytes = Encoding.UTF8.GetBytes("foobar");
             Assert.AreEqual(Utilities.ComputeSha1Hash(bytes), "8843D7F92416211DE9EBB963FF4CE28125932878");
         }
+
+        [TestMethod]
+        public void TestGetMacAddress()
+        {
+            var macAddress = Utilities.GetMacAddress();
+            Assert.IsNotNull(macAddress);
+        }
     }
 }