From 4e08d6ea050bfbff304e7a3d9b9c1c6920d5078d Mon Sep 17 00:00:00 2001 From: Aaron Ai Date: Sun, 23 Apr 2023 22:47:17 +0800 Subject: [PATCH] Merging code in the protected branch requires mandatory approval from code review (#497) --- .asf.yaml | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/.asf.yaml b/.asf.yaml index bcf6e67c5..4f5661ebb 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -38,13 +38,17 @@ github: rebase: false protected_branches: master: + required_pull_request_reviews: + dismiss_stale_reviews: true + require_code_owner_reviews: false + required_approving_review_count: 1 required_status_checks: contexts: - codespell-check - build-result notifications: - commits: commits@rocketmq.apache.org - issues: commits@rocketmq.apache.org + commits: commits@rocketmq.apache.org + issues: commits@rocketmq.apache.org pullrequests: commits@rocketmq.apache.org - jobs: commits@rocketmq.apache.org - discussions: dev@rocketmq.apache.org + jobs: commits@rocketmq.apache.org + discussions: dev@rocketmq.apache.org