From 8502bf1b1347fb44cc50dbe4d83803fa64e38228 Mon Sep 17 00:00:00 2001 From: Aaron Ai Date: Fri, 31 Mar 2023 21:40:41 +0800 Subject: [PATCH] Ensure the compatibility of modifications to the RocketMQ Java client code with OpenTelemetry instrumentation --- .github/workflows/java_build.yml | 20 +++++++++++++++++++ .../example/ProducerNormalMessageExample.java | 1 + 2 files changed, 21 insertions(+) diff --git a/.github/workflows/java_build.yml b/.github/workflows/java_build.yml index 9c384eb23..bbbb4762b 100644 --- a/.github/workflows/java_build.yml +++ b/.github/workflows/java_build.yml @@ -21,3 +21,23 @@ jobs: - name: Build with Maven working-directory: ./java run: mvn -B package --file pom.xml + opentelemetry-compatibility: + name: "OpenTelemetry Instrumentation Compatibility Test" + runs-on: ubuntu-latest + steps: + - name: Checkout Code + uses: actions/checkout@v2 + with: + repository: open-telemetry/opentelemetry-java-instrumentation + ref: main + - name: Use JDK 17 + uses: actions/setup-java@v2 + with: + java-version: 17 + distribution: "adopt" + cache: gradle + - name: Build Code + run: | + cd opentelemetry-java-instrumentation + ./gradlew :instrumentation:rocketmq:rocketmq-client:rocketmq-client-5.0:javaagent:test + diff --git a/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerNormalMessageExample.java b/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerNormalMessageExample.java index b0dde2cae..fe0b2220b 100644 --- a/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerNormalMessageExample.java +++ b/java/client/src/main/java/org/apache/rocketmq/client/java/example/ProducerNormalMessageExample.java @@ -50,6 +50,7 @@ public static void main(String[] args) throws ClientException, IOException { .setEndpoints(endpoints) .setCredentialProvider(sessionCredentialsProvider) .build(); + String topic = "yourNormalTopic"; // In most case, you don't need to create too many producers, singleton pattern is recommended. final Producer producer = provider.newProducerBuilder()