Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AsyncAppender support #363

Merged
merged 1 commit into from
Feb 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion java/client-shade/src/main/resources/rocketmq.logback.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<charset class="java.nio.charset.Charset">UTF-8</charset>
</encoder>
</appender>
<appender name="DefaultAppender" class="org.apache.rocketmq.shaded.ch.qos.logback.core.rolling.RollingFileAppender">
<appender name="DefaultAppenderInner" class="org.apache.rocketmq.shaded.ch.qos.logback.core.rolling.RollingFileAppender">
<append>true</append>
<File>
${rocketmq.log.root:-${user.home}${file.separator}logs${file.separator}rocketmq}${file.separator}rocketmq-client.log
Expand All @@ -43,6 +43,9 @@
<charset class="java.nio.charset.Charset">UTF-8</charset>
</encoder>
</appender>
<appender name="DefaultAppender" class="org.apache.rocketmq.shaded.ch.qos.logback.classic.AsyncAppender">
<appender-ref ref="DefaultAppenderInner"/>
</appender>
<root level="${rocketmq.log.level:-info}">
<appender-ref ref="CustomConsoleAppender"/>
<appender-ref ref="DefaultAppender" additivity="false"/>
Expand Down
5 changes: 4 additions & 1 deletion java/client/src/main/resources/logback.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<charset class="java.nio.charset.Charset">UTF-8</charset>
</encoder>
</appender>
<appender name="DefaultAppender" class="ch.qos.logback.core.rolling.RollingFileAppender">
<appender name="DefaultAppenderInner" class="ch.qos.logback.core.rolling.RollingFileAppender">
<append>true</append>
<File>
${rocketmq.log.root:-${user.home}${file.separator}logs${file.separator}rocketmq}${file.separator}rocketmq-client.log
Expand All @@ -43,6 +43,9 @@
<charset class="java.nio.charset.Charset">UTF-8</charset>
</encoder>
</appender>
<appender name="DefaultAppender" class="ch.qos.logback.classic.AsyncAppender">
<appender-ref ref="DefaultAppenderInner"/>
</appender>
<root level="${rocketmq.log.level:-info}">
<appender-ref ref="CustomConsoleAppender"/>
<appender-ref ref="DefaultAppender" additivity="false"/>
Expand Down