Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(executors): implement disposable #6323

Merged
merged 3 commits into from
Jul 5, 2024
Merged

feat(executors): implement disposable #6323

merged 3 commits into from
Jul 5, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Jul 5, 2024

This PR allows to use executors with Explicit Resource Management;
https://www.typescriptlang.org/docs/handbook/release-notes/typescript-5-2.html#using-declarations-and-explicit-resource-management

await using executor = buildWSExecutor(...)

Copy link

changeset-bot bot commented Jul 5, 2024

🦋 Changeset detected

Latest commit: 1fef94a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@graphql-tools/executor-graphql-ws Minor
@graphql-tools/executor-legacy-ws Minor
@graphql-tools/executor-http Minor
@graphql-tools/utils Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 5, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/executor-graphql-ws 1.2.0-alpha-20240705110827-1fef94a25ba18b5ae498ae9aa88fde050ae610cd npm ↗︎ unpkg ↗︎
@graphql-tools/executor-http 1.1.0-alpha-20240705110827-1fef94a25ba18b5ae498ae9aa88fde050ae610cd npm ↗︎ unpkg ↗︎
@graphql-tools/executor-legacy-ws 1.1.0-alpha-20240705110827-1fef94a25ba18b5ae498ae9aa88fde050ae610cd npm ↗︎ unpkg ↗︎
@graphql-tools/utils 10.3.0-alpha-20240705110827-1fef94a25ba18b5ae498ae9aa88fde050ae610cd npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Jul 5, 2024

💻 Website Preview

The latest changes are available as preview in: https://ff24a433.graphql-tools.pages.dev

Copy link
Contributor

github-actions bot commented Jul 5, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 332       ✗ 0  
     data_received..................: 39 MB   3.8 MB/s
     data_sent......................: 142 kB  14 kB/s
     http_req_blocked...............: avg=13.91µs  min=1.92µs   med=2.64µs   max=1.8ms    p(90)=3.88µs   p(95)=4.66µs 
     http_req_connecting............: avg=10.42µs  min=0s       med=0s       max=1.73ms   p(90)=0s       p(95)=0s     
     http_req_duration..............: avg=56.28ms  min=48.06ms  med=52.53ms  max=143.25ms p(90)=68.54ms  p(95)=86.4ms 
       { expected_response:true }...: avg=56.28ms  min=48.06ms  med=52.53ms  max=143.25ms p(90)=68.54ms  p(95)=86.4ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 166
     http_req_receiving.............: avg=129.89µs min=103.59µs med=126.75µs max=283.65µs p(90)=145.84µs p(95)=158.3µs
     http_req_sending...............: avg=25.07µs  min=19.29µs  med=24.24µs  max=91.45µs  p(90)=29.16µs  p(95)=32.63µs
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s     
     http_req_waiting...............: avg=56.13ms  min=47.9ms   med=52.37ms  max=142.87ms p(90)=68.38ms  p(95)=86.25ms
     http_reqs......................: 166     16.529069/s
     iteration_duration.............: avg=60.48ms  min=52.25ms  med=56.82ms  max=150.67ms p(90)=73.69ms  p(95)=90.43ms
     iterations.....................: 166     16.529069/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

@ardatan ardatan merged commit cacf20f into master Jul 5, 2024
29 checks passed
@ardatan ardatan deleted the disposable-executors branch July 5, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant