Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(executor-http): add disposable option #6325

Merged
merged 4 commits into from
Jul 5, 2024
Merged

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Jul 5, 2024

Executor is no longer Disposable by default so you have to enable it with disposable: true option;

See Explicit Resource Management

Copy link

changeset-bot bot commented Jul 5, 2024

🦋 Changeset detected

Latest commit: 31c38d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@graphql-tools/executor-http Patch
@graphql-tools/utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ardatan ardatan changed the title enhance(executor-http): add disposability lazily enhance(executor-http): add disposable option Jul 5, 2024
Copy link
Contributor

github-actions bot commented Jul 5, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/executor-http 1.1.1-alpha-20240705161243-31c38d9db4400e9be58cf584de0a43ffc7446237 npm ↗︎ unpkg ↗︎
@graphql-tools/utils 10.3.1-alpha-20240705161243-31c38d9db4400e9be58cf584de0a43ffc7446237 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Jul 5, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 334       ✗ 0  
     data_received..................: 39 MB   3.9 MB/s
     data_sent......................: 143 kB  14 kB/s
     http_req_blocked...............: avg=13.46µs min=2.07µs   med=2.59µs   max=1.74ms   p(90)=3.98µs   p(95)=4.38µs  
     http_req_connecting............: avg=10.02µs min=0s       med=0s       max=1.67ms   p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=55.89ms min=47.32ms  med=51.93ms  max=152.57ms p(90)=64.07ms  p(95)=87.43ms 
       { expected_response:true }...: avg=55.89ms min=47.32ms  med=51.93ms  max=152.57ms p(90)=64.07ms  p(95)=87.43ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 167
     http_req_receiving.............: avg=130.8µs min=100.71µs med=127.86µs max=295.25µs p(90)=149.75µs p(95)=153.65µs
     http_req_sending...............: avg=24.33µs min=15.55µs  med=23.26µs  max=72.34µs  p(90)=29.75µs  p(95)=34.47µs 
     http_req_tls_handshaking.......: avg=0s      min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=55.74ms min=47.18ms  med=51.79ms  max=152.2ms  p(90)=63.92ms  p(95)=87.26ms 
     http_reqs......................: 167     16.655251/s
     iteration_duration.............: avg=60.01ms min=50.91ms  med=56.17ms  max=158.18ms p(90)=68.96ms  p(95)=91.71ms 
     iterations.....................: 167     16.655251/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Copy link
Contributor

github-actions bot commented Jul 5, 2024

💻 Website Preview

The latest changes are available as preview in: https://daa3b3e0.graphql-tools.pages.dev

@ardatan ardatan merged commit 9792e80 into master Jul 5, 2024
30 checks passed
@ardatan ardatan deleted the make-lazily-disposable branch July 5, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant