Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle AggregateErrors by expanding them to result errors and other smaller improvements #6354

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

enisdenjo
Copy link
Collaborator

No description provided.

@enisdenjo enisdenjo requested a review from ardatan July 18, 2024 11:32
Copy link

changeset-bot bot commented Jul 18, 2024

🦋 Changeset detected

Latest commit: fd35fdc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-tools/executor-http Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 18, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/executor-http 1.1.5-alpha-20240718115638-fd35fdc4aaa3ed1a95df3d0bcb0bc1250e773a37 npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Jul 18, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 336       ✗ 0  
     data_received..................: 39 MB   3.9 MB/s
     data_sent......................: 144 kB  14 kB/s
     http_req_blocked...............: avg=19.46µs  min=2.07µs   med=2.51µs   max=2.78ms   p(90)=3.67µs   p(95)=3.86µs  
     http_req_connecting............: avg=16.15µs  min=0s       med=0s       max=2.71ms   p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=55.56ms  min=47.63ms  med=51.76ms  max=154.18ms p(90)=59.27ms  p(95)=87.03ms 
       { expected_response:true }...: avg=55.56ms  min=47.63ms  med=51.76ms  max=154.18ms p(90)=59.27ms  p(95)=87.03ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 168
     http_req_receiving.............: avg=127.14µs min=100.73µs med=125.49µs max=279.28µs p(90)=137.79µs p(95)=151.83µs
     http_req_sending...............: avg=25.24µs  min=19.16µs  med=23.51µs  max=106.27µs p(90)=29.14µs  p(95)=33.52µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=55.41ms  min=47.48ms  med=51.61ms  max=153.8ms  p(90)=59.12ms  p(95)=86.88ms 
     http_reqs......................: 168     16.735614/s
     iteration_duration.............: avg=59.72ms  min=51.98ms  med=55.79ms  max=163.14ms p(90)=62.86ms  p(95)=91.15ms 
     iterations.....................: 168     16.735614/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Copy link
Contributor

github-actions bot commented Jul 18, 2024

💻 Website Preview

The latest changes are available as preview in: https://7979a159.graphql-tools.pages.dev

@enisdenjo enisdenjo merged commit 97c88a0 into master Jul 18, 2024
26 of 27 checks passed
@enisdenjo enisdenjo deleted the exec-httpagg-errs branch July 18, 2024 11:55
@enisdenjo enisdenjo changed the title Handle AggregateErrors by expanding them to result errors Handle AggregateErrors by expanding them to result errors and other smaller improvements Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant