-
-
Notifications
You must be signed in to change notification settings - Fork 805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(federation): merge errors for shared root fields correctly #6355
Conversation
🦋 Changeset detectedLatest commit: 7fe3587 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Benchmark Results
|
🚀 Snapshot Release (
|
Package | Version | Info |
---|---|---|
@graphql-tools/executor-http |
1.1.5-alpha-20240718123353-7fe3587eed6cb8a9f672a63184b5acaede6538e5 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/federation |
2.1.2-alpha-20240718123353-7fe3587eed6cb8a9f672a63184b5acaede6538e5 |
npm ↗︎ unpkg ↗︎ |
💻 Website PreviewThe latest changes are available as preview in: https://2697a53f.graphql-tools.pages.dev |
bdbed92
to
43ca38c
Compare
43ca38c
to
0723f9b
Compare
Handle errors coming from subgraphs correctly when a root field is shared by different subgraphs
Query.foo
, and subgraph B returns the data, ignore the error and keep it for null fields.AggregateError
then return them to the gateway result.