Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Add support to enable ISIS authentication at global level #4102

Draft
wants to merge 17 commits into
base: devel
Choose a base branch
from
Draft

Feat(eos_designs): Add support to enable ISIS authentication at global level #4102

wants to merge 17 commits into from

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Jun 12, 2024 •
edited

Change Summary

Add support to enable ISIS authentication at global level.

Related Issue(s)

Fixes #3674

Component(s) name

arista.avd.eos_designs

Proposed changes

ISIS authentication is not enabled by default when enabling ISIS as the underlay protocol for the fabric. It would be great to have a global knob to enable authentication in the fabric links like we do for BGP.

How to test

Add underlay_isis_authentication_mode and underlay_isis_authentication_key at global level.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions GitHub Actions
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4102
# Activate the virtual environment
source test-avd-pr-4102/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@isis_authentication#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,isis_authentication --force
# Optional: Install AVD examples
cd test-avd-pr-4102
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jun 12, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@laxmikantchintakindi laxmikantchintakindi marked this pull request as ready for review June 14, 2024 06:58
@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft June 14, 2024 16:13
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Jun 17, 2024
@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Jun 18, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jun 18, 2024
@github-actions github-actions bot added the state: conflict PR with conflict label Jun 18, 2024
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added state: conflict PR with conflict and removed state: conflict PR with conflict role: eos_cli_config_gen issue related to eos_cli_config_gen role labels Jun 18, 2024
@github-actions GitHub Actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: conflict PR with conflict labels Jun 19, 2024
ClausHolbechArista
ClausHolbechArista requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a test where you cover the underlay + mlag case.

@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft July 24, 2024 05:38
@laxmikantchintakindi
Copy link
Contributor Author

Keeping this in draft untill #4254 is merged.

@Shivani-gslab Shivani-gslab mentioned this pull request Jul 24, 2024
Merged
4 tasks
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Jul 31, 2024
Laxmikant Chintakindi and others added 16 commits August 5, 2024 19:24
Feat(eos_designs): Add support to enable ISIS authentication at globa…
0311a9e 
…l level
Adding EOL in schema.
06f56ce
Fixing CI failure.
cd05692
Making seperate files for the keys.
00f2076
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
cb1ebd0 
for more information, see https://pre-commit.ci
Adding isis authentication sha, shared-secret.
6fd21bf
removing empty schema file.
fdf950e
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e9c4fcf 
for more information, see https://pre-commit.ci
Removing empty schema file.
c0c5c72
added description.
a0abc47
Correcting order of cli as per the comment.
408b614
Changing the design schema completely.
329b2c1
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
f201e3f 
for more information, see https://pre-commit.ci
Remove nulls.
89fe2db
Fixing the schema and code.
27eb442
rebase
491e7c0
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 5, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Aug 5, 2024
@ClausHolbechArista
Copy link
Contributor

The change for eos_cli_config_gen has been merged now.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vibhu-gslab Vibhu-gslab Vibhu-gslab left review comments

@ClausHolbechArista ClausHolbechArista ClausHolbechArista requested changes

@MaheshGSLAB MaheshGSLAB MaheshGSLAB approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@laxmikantchintakindi laxmikantchintakindi

Labels
role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ISIS global knob to enable authentication
4 participants
@laxmikantchintakindi @ClausHolbechArista @Vibhu-gslab @MaheshGSLAB