Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_validate_state): Added the validation for DPS interface reachability #4154

Merged
merged 13 commits into from
Aug 28, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Added the validation for DPS interface reachability

Related Issue(s)

Fixes #4150

Component(s) name

arista.avd.eos_validate_state

Proposed changes

Added the validation for DPS interface reachability. You will see VerifyReachability tests with DPS interface.

How to test

Run molecule or test on lab having WAN designs

Checklist

User Checklist

  • Verified the changes by running pre-commit and all molecules.
  • Implemented only those commands whose output is seen on show running-config command.
  • Along with EOS config template, updated the documentation template as well.
  • Add the test-case in molecules.
  • Tested the generated config through eapi or cvp on lab.
  • Added meaningfully variable names.
  • Added description only if they provide extra information apart from the key.
  • Do not using helping words in description.
  • Added punctuation to all descriptions.
  • One row per entry (per primary key) for documentation template.
  • If making any key "deprecated", Make sure to move tests with this to the deprecated_vars molecule and make sure to add a test if we are missing it .
  • Use for key names in description. eg. name.
  • Use plural key names if it has multiple elements like- sample_policies.
  • Try to keep less indented j2 code.
  • Used natural sort for "for loops" in j2 templates (after checking on EOS CLI).
  • If checking child key avoid checking parent key before it (arista.avd.defined).
  • Do not show passwords and password type in documents. Hide it using 'arista.avd.hide_passwords' filter. Dont add column for passwords and password type in documents.
  • Order of config should be as per EOS cli.
  • Add exclamatory marks(!) at correct position in templates. It should be same as reflected in run-config.
  • Do not use inline if/else in jinja, since it becomes much harder to read the template.
  • Do all possible unit test for config and python code

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB self-assigned this Jun 25, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4154
# Activate the virtual environment
source test-avd-pr-4154/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4150#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4150 --force
# Optional: Install AVD examples
cd test-avd-pr-4154
ansible-playbook arista.avd.install_examples

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review June 26, 2024 06:45
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners June 26, 2024 06:45
@MaheshGSLAB MaheshGSLAB requested a review from gmuloc July 19, 2024 11:46
@github-actions github-actions bot added the state: conflict PR with conflict label Aug 2, 2024
Copy link

github-actions bot commented Aug 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carl-baillargeon carl-baillargeon added the one approval This PR has one approval and is only missing one more. label Aug 12, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Aug 13, 2024
@github-actions github-actions bot removed the state: conflict PR with conflict label Aug 28, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

sonarcloud bot commented Aug 28, 2024

@gmuloc gmuloc merged commit 7b0f4a5 into aristanetworks:devel Aug 28, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_validate_state): Add validation for DPS reachability
3 participants