Feat(eos_designs): Add ptp_settings to replace ptp key in eos_designs
#4155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4155
# Activate the virtual environment
source test-avd-pr-4155/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@ptp#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,ptp --force
# Optional: Install AVD examples
cd test-avd-pr-4155
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
state: CI Updated
laxmikantchintakindi
changed the title
MaheshGSLAB
reviewed
Jun 27, 2024
python-avd/pyavd/_eos_designs/schema/schema_fragments/ptp_settings.schema.yml
Outdated
Show resolved
Hide resolved
MaheshGSLAB
reviewed
Jun 27, 2024
ansible_collections/arista/avd/roles/eos_designs/docs/tables/ptp.md
Outdated
Show resolved
Hide resolved
ClausHolbechArista
requested changes
Jun 27, 2024
python-avd/pyavd/_eos_designs/schema/schema_fragments/ptp_settings.schema.yml
Outdated
Show resolved
Hide resolved
github-actions
bot
added
type: documentation
github-actions
bot
added
the
role: eos_cli_config_gen
github-actions
bot
removed
type: documentation
Vibhu-gslab
requested review from
ClausHolbechArista,
Shivani-gslab and
MaheshGSLAB
MaheshGSLAB
previously approved these changes
Jul 8, 2024
gmuloc
added
the
one approval
Co-authored-by: Claus Holbech <[email protected]>
…riables.md Co-authored-by: Claus Holbech <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
laxmikantchintakindi
force-pushed
the
ptp
branch
from
895f233
to
0672938
Compare
…riables.md Co-authored-by: Claus Holbech <[email protected]>
ClausHolbechArista
approved these changes
Jul 24, 2024
ClausHolbechArista
dismissed stale reviews from MaheshGSLAB and Vibhu-gslab
many changes since the review
ClausHolbechArista
changed the title
ptp_settings to replace ptp key in eos_designs
|
gmuloc
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Rename ptp key to ptp_settings to avoid conflicting variable with eos_cli_config_gen.
Related Issue(s)
Fixes #3236
Component(s) name
arista.avd.eos_designsProposed changes
How to test
Checklist
User Checklist
Repository Checklist