Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add switchport data model #4158

Merged

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Jun 26, 2024

Change Summary

Refactor eos_cli_config_gen switchport data models

Related Issue(s)

Fixes #2288

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Adding switchport to ethernet-interfaces and port-channel interfaces schema and template.

Config for switchport.tap and switchport.tool is implemented in PR #4174

  • Added new schema section for switchport keys.
  • Updated config and doc template to implement new keys.
  • Deprecated old keys for switchport.
  • Updated the documentation template logic to handle the condition for type key.
  • Updated molecule tests regarding all the changes.

How to test

Molecule tests are added. Test in EOS CLI.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4158
# Activate the virtual environment
source test-avd-pr-4158/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@switchport_trunk#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,switchport_trunk --force
# Optional: Install AVD examples
cd test-avd-pr-4158
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jun 26, 2024
@Shivani-gslab Shivani-gslab marked this pull request as ready for review June 28, 2024 07:07
@Shivani-gslab Shivani-gslab requested review from a team as code owners June 28, 2024 07:07
@Shivani-gslab Shivani-gslab marked this pull request as draft July 1, 2024 11:33
@Shivani-gslab Shivani-gslab force-pushed the switchport_trunk branch 2 times, most recently from 5cb63a1 to 7823203 Compare July 2, 2024 10:47
@Shivani-gslab Shivani-gslab marked this pull request as ready for review July 2, 2024 10:50
@Shivani-gslab Shivani-gslab marked this pull request as draft July 4, 2024 12:19
@Shivani-gslab Shivani-gslab force-pushed the switchport_trunk branch 2 times, most recently from f34955b to f9b9286 Compare July 9, 2024 05:18
@Shivani-gslab Shivani-gslab marked this pull request as ready for review July 9, 2024 05:24
@Shivani-gslab Shivani-gslab marked this pull request as draft July 15, 2024 05:32
@Shivani-gslab Shivani-gslab force-pushed the switchport_trunk branch 2 times, most recently from 3c71198 to 023fe1b Compare July 15, 2024 10:25
@Shivani-gslab Shivani-gslab marked this pull request as ready for review August 21, 2024 14:30
Co-authored-by: laxmikantchintakindi <[email protected]>
@Shivani-gslab Shivani-gslab marked this pull request as draft August 22, 2024 07:41
Copy link

sonarcloud bot commented Aug 23, 2024

@ClausHolbechArista ClausHolbechArista merged commit 43c657e into aristanetworks:devel Aug 23, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor eos_cli_config_gen switchport data models
4 participants