Feat(eos_designs): Add support to add access-groups on l3-interfaces through network-services #4163

laxmikantchintakindi · 2024-06-26T17:34:48Z

Change Summary

Add support to add access-groups on l3-interfaces through network-services

Related Issue(s)

Fixes #3534
Only address the L3 interfaec but not the SVIs as it was already implemented in #4096.

Component(s) name

arista.avd.eos_designs

Proposed changes

Initial ask

It would be nice when defining a L3 / SVI in network services to also be able to add an access group right there. That was the tags take care of only adding the L3/SVI as it already does but also only add the access group to the devices that need it.

This PR covers the L3 interfaces part in network services - SVIs was done in #4096

How to test

Checklist

User Checklist

N/A

Repository Checklist

My code has been rebased from devel before I start
I have read the CONTRIBUTING document.
My change requires a change to the documentation and documentation have been updated accordingly.
I have updated molecule CI testing accordingly. (check the box if not applicable)

github-actions · 2024-06-26T17:35:03Z

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4163
# Activate the virtual environment
source test-avd-pr-4163/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@access_groups#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,access_groups --force
# Optional: Install AVD examples
cd test-avd-pr-4163
ansible-playbook arista.avd.install_examples

python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py

gmuloc

So the PR only partially fix the issue as it is asking for l3_interfaces and SVIs and the PR currently implements only l3_interfaces.

I feel like the code to compute the access_list is a bit of a repeat from the one we have for l3_interfaces under node but maybe there was no easy way to reuse it?

Otherwise it looks good to me if we accept the fact that it is a partial fix.

Can you please remove the comments from the schema?

python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml

python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py

...a/avd/molecule/eos_designs_unit_tests/inventory/group_vars/DC1_TENANTS_NETWORKS/Tenant_A.yml

...lections/arista/avd/molecule/eos_designs_unit_tests/intended/structured_configs/DC1-BL1B.yml

github-actions · 2024-07-02T08:52:44Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

github-actions · 2024-07-02T12:37:56Z

Conflicts have been resolved. A maintainer will review the pull request shortly.

Many changes since this review.

python-avd/pyavd/_eos_designs/structured_config/network_services/ethernet_interfaces.py

python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py

…through network-services

for more information, see https://pre-commit.ci

python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py

…es/utils.py Co-authored-by: Claus Holbech <[email protected]>

for more information, see https://pre-commit.ci

python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml

python-avd/pyavd/_eos_designs/structured_config/network_services/ip_access_lists.py

…es/ip_access_lists.py Co-authored-by: Guillaume Mulocher <[email protected]>

...a/avd/molecule/eos_designs_unit_tests/inventory/group_vars/DC1_TENANTS_NETWORKS/Tenant_A.yml

sonarcloud · 2024-07-26T13:16:46Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

github-actions bot assigned laxmikantchintakindi Jun 26, 2024

github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jun 26, 2024

MaheshGSLAB reviewed Jun 27, 2024

View reviewed changes

python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py Show resolved Hide resolved

python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py Outdated Show resolved Hide resolved

laxmikantchintakindi force-pushed the access_groups branch from 93ff5f4 to 476a7ec Compare June 28, 2024 06:00

MaheshGSLAB previously approved these changes Jun 28, 2024

View reviewed changes

MaheshGSLAB marked this pull request as ready for review June 28, 2024 06:50

MaheshGSLAB requested review from a team as code owners June 28, 2024 06:50

gmuloc requested changes Jul 2, 2024

View reviewed changes

python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml Outdated Show resolved Hide resolved

python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py Show resolved Hide resolved

ClausHolbechArista reviewed Jul 2, 2024

View reviewed changes

laxmikantchintakindi marked this pull request as draft July 2, 2024 08:22

github-actions bot added the state: conflict PR with conflict label Jul 2, 2024

github-actions bot removed the state: conflict PR with conflict label Jul 2, 2024

laxmikantchintakindi marked this pull request as ready for review July 2, 2024 14:19

laxmikantchintakindi requested review from ClausHolbechArista and gmuloc July 4, 2024 05:01

laxmikantchintakindi force-pushed the access_groups branch from 63be638 to 0f77a4a Compare July 16, 2024 12:46

ClausHolbechArista requested changes Jul 22, 2024

View reviewed changes

python-avd/pyavd/_eos_designs/structured_config/network_services/ethernet_interfaces.py Outdated Show resolved Hide resolved

python-avd/pyavd/_eos_designs/structured_config/network_services/utils.py Outdated Show resolved Hide resolved

laxmikantchintakindi force-pushed the access_groups branch from 3fe14ed to e0ca9ee Compare July 23, 2024 10:54

Laxmikant Chintakindi added 5 commits July 26, 2024 12:50

Feat(eos_designs): Add support to add access-groups on l3-interfaces …

5451e2e

…through network-services

Using ipaddress module in the code.

4a82e03

Fixing the logic for acls.

d2bc757

Adding convert types to ipv4 acl schema.

c01dc9d

Adding new interfaces for the test cases.

12d2923

Laxmikant Chintakindi and others added 6 commits July 26, 2024 12:50

Fixing CI.

87e1fef

Fixing docstring.

1937d45

Update code add relevant acls only.

db22cb5

[pre-commit.ci] auto fixes from pre-commit.com hooks

a5c96aa

for more information, see https://pre-commit.ci

Removing unnecessary key from dict.

23f74c0

Remove comments.

6699db2

laxmikantchintakindi force-pushed the access_groups branch from 239f7ca to 6699db2 Compare July 26, 2024 07:20

[pre-commit.ci] auto fixes from pre-commit.com hooks

f2bdab7

for more information, see https://pre-commit.ci

ClausHolbechArista requested changes Jul 26, 2024

View reviewed changes

laxmikantchintakindi and others added 4 commits July 26, 2024 13:16

Update python-avd/pyavd/_eos_designs/structured_config/network_servic…

9c6c367

…es/utils.py Co-authored-by: Claus Holbech <[email protected]>

Update python-avd/pyavd/_eos_designs/structured_config/network_servic…

3283d46

…es/utils.py Co-authored-by: Claus Holbech <[email protected]>

Update python-avd/pyavd/_eos_designs/structured_config/network_servic…

3d3629a

…es/utils.py Co-authored-by: Claus Holbech <[email protected]>

[pre-commit.ci] auto fixes from pre-commit.com hooks

0b1272b

for more information, see https://pre-commit.ci

gmuloc added this to the v4.10.0 milestone Jul 26, 2024

gmuloc reviewed Jul 26, 2024

View reviewed changes

python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml Show resolved Hide resolved

gmuloc reviewed Jul 26, 2024

View reviewed changes

python-avd/pyavd/_eos_designs/structured_config/network_services/ip_access_lists.py Outdated Show resolved Hide resolved

Update python-avd/pyavd/_eos_designs/structured_config/network_servic…

67d4f44

…es/ip_access_lists.py Co-authored-by: Guillaume Mulocher <[email protected]>

gmuloc approved these changes Jul 26, 2024

View reviewed changes

gmuloc reviewed Jul 26, 2024

View reviewed changes

...a/avd/molecule/eos_designs_unit_tests/inventory/group_vars/DC1_TENANTS_NETWORKS/Tenant_A.yml Outdated Show resolved Hide resolved

gmuloc added the one approval This PR has one approval and is only missing one more. label Jul 26, 2024

gmuloc requested a review from ClausHolbechArista July 26, 2024 09:25

Adding subinterface tests.

8f554e8

MaheshGSLAB approved these changes Jul 26, 2024

View reviewed changes

ClausHolbechArista approved these changes Jul 26, 2024

View reviewed changes

ClausHolbechArista added 2 commits July 26, 2024 13:53

Merge branch 'devel' into access_groups

ed0d9dd

Merge branch 'devel' into access_groups

90c19da

ClausHolbechArista merged commit 1504059 into aristanetworks:devel Jul 26, 2024
41 checks passed

github-actions bot added the rn: Feat(eos_designs) label Jul 26, 2024

laxmikantchintakindi deleted the access_groups branch July 30, 2024 08:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat(eos_designs): Add support to add access-groups on l3-interfaces through network-services #4163

Feat(eos_designs): Add support to add access-groups on l3-interfaces through network-services #4163

laxmikantchintakindi commented Jun 26, 2024 •

edited by gmuloc

Loading

github-actions bot commented Jun 26, 2024

gmuloc left a comment

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

sonarcloud bot commented Jul 26, 2024

Feat(eos_designs): Add support to add access-groups on l3-interfaces through network-services #4163

Feat(eos_designs): Add support to add access-groups on l3-interfaces through network-services #4163

Conversation

laxmikantchintakindi commented Jun 26, 2024 • edited by gmuloc Loading

Change Summary

Related Issue(s)

Component(s) name

Proposed changes

How to test

Checklist

User Checklist

Repository Checklist

github-actions bot commented Jun 26, 2024

gmuloc left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 2, 2024

github-actions bot commented Jul 2, 2024

sonarcloud bot commented Jul 26, 2024

Quality Gate passed

laxmikantchintakindi commented Jun 26, 2024 •

edited by gmuloc

Loading