-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Underlay OSPF authentication #4169
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4169
# Activate the virtual environment
source test-avd-pr-4169/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/jonxstill/ansible-avd.git@underlay_ospf_auth#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/jonxstill/ansible-avd.git#/ansible_collections/arista/avd/,underlay_ospf_auth --force
# Optional: Install AVD examples
cd test-avd-pr-4169
ansible-playbook arista.avd.install_examples |
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4169
# Activate the virtual environment
source test-avd-pr-4169/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/jonxstill/ansible-avd.git@underlay_ospf_auth#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/jonxstill/ansible-avd.git#/ansible_collections/arista/avd/,underlay_ospf_auth --force
# Optional: Install AVD examples
cd test-avd-pr-4169
ansible-playbook arista.avd.install_examples |
891a9df
to
142707d
Compare
python-avd/pyavd/_eos_designs/schema/schema_fragments/underlay_ospf_authentication_schema.yml
Outdated
Show resolved
Hide resolved
ba3298b
to
fad40cb
Compare
python-avd/pyavd/_eos_designs/schema/schema_fragments/underlay_ospf_authentication_schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/structured_config/underlay/ethernet_interfaces.py
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/underlay_ospf_authentication_schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/underlay_ospf_authentication_schema.yml
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/underlay_ospf_authentication_schema.yml
Show resolved
Hide resolved
9e71f0a
to
44abba2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me overall. Suggesting improving the test a bit for two keys but otherwise all good.
...lections/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/MLAG_OSPF_TESTS.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/underlay_ospf_authentication_schema.yml
Outdated
Show resolved
Hide resolved
…_ospf_authentication_schema.yml
for more information, see https://pre-commit.ci
python-avd/pyavd/_eos_designs/schema/schema_fragments/underlay_ospf_authentication_schema.yml
Show resolved
Hide resolved
…_ospf_authentication_schema.yml
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Automatic encryption of underlay OSPF message digest keys for use in underlay.
Component(s) name
arista.avd.eos_designs
Proposed changes
Because OSPF message-digest keys are encrypted in EOS configurations, using the interface name as the key, it requires inline Jinja2 (or offline encryption of keys) to generate the type 7 passwords required. This PR automates this process.
Schema Changes:
How to test
Molecule tests added in
eos_designs_unit_tests
andevpn_underlay_ospf_overlay_ebgp
.Test manually by adding above YAML at fabric level with ospf configured as the underlay.
Checklist
Repository Checklist