Feat(eos_designs): MLAG secondary should use short-esi from MLAG primary #4172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4172
# Activate the virtual environment
source test-avd-pr-4172/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@short_esi_auto#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,short_esi_auto --force
# Optional: Install AVD examples
cd test-avd-pr-4172
ansible-playbook arista.avd.install_examples |
Vibhu-gslab
force-pushed
the
short_esi_auto
branch
from
610f1b8
to
ae04547
Compare
github-actions
bot
added
the
state: CI Updated
ClausHolbechArista
requested changes
Jul 2, 2024
...e_collections/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/DC1_FABRIC.yml
Outdated
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
short_esi_auto
branch
from
a1858bc
to
d574ede
Compare
Vibhu-gslab
force-pushed
the
short_esi_auto
branch
from
d574ede
to
5b25372
Compare
MaheshGSLAB
previously approved these changes
Jul 9, 2024
gmuloc
reviewed
Jul 9, 2024
ClausHolbechArista
requested changes
Jul 22, 2024
Vibhu-gslab
force-pushed
the
short_esi_auto
branch
2 times, most recently
from
b80e2a0
to
a76a089
Compare
ClausHolbechArista
requested changes
Jul 24, 2024
Vibhu-gslab
force-pushed
the
short_esi_auto
branch
from
a76a089
to
a6689fe
Compare
ClausHolbechArista
approved these changes
Jul 25, 2024
ClausHolbechArista
dismissed stale reviews from MaheshGSLAB and Shivani-gslab
stale review
MaheshGSLAB
reviewed
Jul 25, 2024
Vibhu-gslab
force-pushed
the
short_esi_auto
branch
from
4ca6b0e
to
f589f2c
Compare
MaheshGSLAB
approved these changes
Jul 25, 2024
ClausHolbechArista
approved these changes
Jul 26, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
MLAG secondary should use short-esi from MLAG primary.
Related Issue(s)
Fixes #4124
Component(s) name
arista.avd.eos_designsHow to test
CI will check
Checklist
Repository Checklist