Feat(eos_cli_config_gen): Add switchport 'tap' and 'tool' mode config to the ethernet and port-channel interfaces

[Shivani-gslab]

Change Summary

Add switchport 'tap' and 'tool' mode config to the interfaces

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Add schema, template and tests for switchport.tap and switchport.tool in interfaces.

How to test

Molecule test added. Test in EOS CLI.

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4174
# Activate the virtual environment
source test-avd-pr-4174/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@switchport_tap_tool#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,switchport_tap_tool --force
# Optional: Install AVD examples
cd test-avd-pr-4174
ansible-playbook arista.avd.install_examples

[MaheshGSLAB]

the cli is bit odd for this option

wan1-dc1(config-if-Et1)#switchport tap identity ?
  <1-4094>   Tap port VLAN ID tag
  <1-65535>  Tap port extended ID

wan1-dc1(config-if-Et1)#switchport tap identity 65533 ?
  <cr>  

wan1-dc1(config-if-Et1)#switchport tap identity 4094 ?
  inner  Configure inner tap port ID tag
  <cr>   

wan1-dc1(config-if-Et1)#switchport tap identity 4095 ?
  <cr>  

We might need to add the condtion of greater then 4094
@gmuloc

[MaheshGSLAB]

Need to check more

[Shivani-gslab]

For me it is like this - [EOS 4.30]

s1-leaf2(config-if-Et1)#switchport tap identity ?
  <1-4094>  Tap port ID tag

s1-leaf2(config-if-Et1)#switchport tap identity 10 ?
  inner  Configure inner tap port ID tag
  <cr>   

[Vibhu-gslab]

If tap identity is greater than 4094 then it shows internal error.

s1-spine1(config-if-Et1)#switchport tap identity 4092
s1-spine1(config-if-Et1)#show active 
interface Ethernet1
   switchport tap identity 4092
   switchport tap mac-address dest 00:01:00:01:00:01 src 00:02:00:02:00:02
   switchport tap encapsulation vxlan strip
   switchport tap encapsulation gre destination 1.1.1.1 source 2.2.2.2 protocol 0xad9c feature header length 3 strip
   switchport tap allowed vlan 10-20
   switchport tap default nexthop-group aaaa adfs asd asdfs ffr
   switchport tap default interface Ethernet3
   switchport tap default interface Ethernet4
   switchport tap default interface Recirc-Channel4
s1-spine1(config-if-Et1)#switchport tap identity 4092 ?
  inner  Configure inner tap port ID tag
  <cr>   

s1-spine1(config-if-Et1)#switchport tap identity 65535 ?
  <cr>  

s1-spine1(config-if-Et1)#switchport tap identity 65535 
s1-spine1(config-if-Et1)#show active 

% Internal error

@ClausHolbechArista

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.