Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Extend GRE span with payload support #4190

Merged
merged 27 commits into from
Aug 21, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

For monitor session default extend GRE span with payload support

Related Issue(s)

Fixes #4160

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Adding support for monitor session default gre

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab self-assigned this Jul 8, 2024
Copy link

github-actions bot commented Jul 8, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4190
# Activate the virtual environment
source test-avd-pr-4190/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@monitor_session#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,monitor_session --force
# Optional: Install AVD examples
cd test-avd-pr-4190
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jul 8, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review July 10, 2024 14:03
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners July 10, 2024 14:03
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Vibhu-gslab Vibhu-gslab marked this pull request as draft July 22, 2024 07:15
@Vibhu-gslab Vibhu-gslab force-pushed the monitor_session branch 3 times, most recently from 0a13fa5 to f52aa94 Compare July 22, 2024 07:57
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review July 22, 2024 09:47
@Vibhu-gslab Vibhu-gslab marked this pull request as draft August 19, 2024 07:09
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review August 19, 2024 09:19
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Aug 21, 2024
Copy link

sonarcloud bot commented Aug 21, 2024

@ClausHolbechArista ClausHolbechArista merged commit ee51f04 into aristanetworks:devel Aug 21, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Extend GRESpan with payload full-packet support
5 participants