Feat(eos_validate_state): Added the validation for AVT path for static peers and role of device #4200
+3,413
−2,997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4200
# Activate the virtual environment
source test-avd-pr-4200/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4188#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4188 --force
# Optional: Install AVD examples
cd test-avd-pr-4200
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_validate_state
state: CI Updated
ansible_collections/arista/avd/roles/eos_validate_state/python_modules/tests/avdtestavt.py
Outdated
Show resolved
Hide resolved
gmuloc
requested changes
Jul 18, 2024
ansible_collections/arista/avd/roles/eos_validate_state/python_modules/tests/avdtestavt.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_validate_state/python_modules/tests/avdtestavt.py
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/docs/how-to/wan.md
Outdated
Show resolved
Hide resolved
MaheshGSLAB
changed the title
gmuloc
reviewed
Jul 25, 2024
ansible_collections/arista/avd/roles/eos_validate_state/python_modules/tests/avdtestavt.py
Outdated
Show resolved
Hide resolved
…_modules/tests/avdtestavt.py Co-authored-by: Guillaume Mulocher <[email protected]>
for more information, see https://pre-commit.ci
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ansible_collections/arista/avd/roles/eos_validate_state/python_modules/tests/avdtestavt.py
Outdated
Show resolved
Hide resolved
carl-baillargeon
added
the
one approval
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Added the validation for AVT path for static peers and role of device.
Related Issue(s)
Fixes #4188
Component(s) name
arista.avd.eos_validate_stateProposed changes
Added the testcase for to verify AVT path and role from ANTA.
How to test
Run the validation playbook on lab or run molecule
Checklist
User Checklist
Repository Checklist