Fix(eos_designs): BGP vlan config should not have redistribute igmp when belonging to a VRF with evpn multicast #4210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4210
# Activate the virtual environment
source test-avd-pr-4210/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@redistribute_igmp#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,redistribute_igmp --force
# Optional: Install AVD examples
cd test-avd-pr-4210
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
type: documentation
Vibhu-gslab
changed the title
python-avd/pyavd/_eos_designs/structured_config/network_services/router_bgp.py
Show resolved
Hide resolved
Vibhu-gslab
force-pushed
the
redistribute_igmp
branch
from
98d8943
to
e639b86
Compare
…hen belonging to a VRF with evpn multicast
for more information, see https://pre-commit.ci
Vibhu-gslab
force-pushed
the
redistribute_igmp
branch
from
e639b86
to
bf94a5d
Compare
ClausHolbechArista
requested changes
Jul 22, 2024
|
Moving to draft until 4.10 has been merged. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
added
state: conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Having redistribute igmp for a svi/vlan belonging to a VRF with evpn multicast is an issue because it could cause conflicts in the control-plane. #3462 (comment)
Related Issue(s)
Fixes #4061
Component(s) name
arista.avd.eos_designsChecklist
Repository Checklist