Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs,eos_cli_config_gen): Support for ipv6 addressing on network services VRFs #4222

Open
wants to merge 33 commits into
base: devel
Choose a base branch
from

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

Add ipv6 virtual source-nat vrf <vrf> support to eos_cli_config_gen and eos_designs.

Related Issue(s)

Fixes #3936 , #4207

Component(s) name

arista.avd.eos_designs
arista.avd.eos_cli_config_gen

Proposed changes

Added ipv6 support for virtual source nat vrfs.

How to test

Added test in molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4222
# Activate the virtual environment
source test-avd-pr-4222/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@vtep_diagnostic_eos_designs#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,vtep_diagnostic_eos_designs --force
# Optional: Install AVD examples
cd test-avd-pr-4222
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jul 17, 2024
@Vibhu-gslab Vibhu-gslab force-pushed the vtep_diagnostic_eos_designs branch 2 times, most recently from 95c1d9f to 9635bd6 Compare July 22, 2024 08:12
@Vibhu-gslab Vibhu-gslab force-pushed the vtep_diagnostic_eos_designs branch 2 times, most recently from 01eead7 to ac1e857 Compare July 26, 2024 10:31
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review July 26, 2024 11:03
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners July 26, 2024 11:03
@Vibhu-gslab Vibhu-gslab marked this pull request as draft July 30, 2024 06:46
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review July 31, 2024 07:17
@MaheshGSLAB MaheshGSLAB requested a review from a team July 31, 2024 07:18
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Jul 31, 2024
Copy link

github-actions bot commented Aug 7, 2024

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs, eos_cli_config_gen): Support for ipv6 virtual source nat vrfs Feat(eos_designs,eos_cli_config_gen): Support for ipv6 virtual source nat vrfs Aug 7, 2024
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_designs,eos_cli_config_gen): Support for ipv6 virtual source nat vrfs Feat(eos_designs,eos_cli_config_gen): Support for ipv6 addressing on network services VRFs Aug 8, 2024
Vibhu-gslab and others added 7 commits August 9, 2024 11:03
…work_services.schema.yml

Co-authored-by: Claus Holbech <[email protected]>
…work_services.schema.yml

Co-authored-by: Claus Holbech <[email protected]>
…work_services.schema.yml

Co-authored-by: Claus Holbech <[email protected]>
…work_services.schema.yml

Co-authored-by: Claus Holbech <[email protected]>
…work_services.schema.yml

Co-authored-by: Claus Holbech <[email protected]>
…es/loopback_interfaces.py

Co-authored-by: Claus Holbech <[email protected]>
…es/loopback_interfaces.py

Co-authored-by: Claus Holbech <[email protected]>
@Vibhu-gslab Vibhu-gslab marked this pull request as draft August 9, 2024 05:46
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review August 9, 2024 06:27
@github-actions github-actions bot added the state: conflict PR with conflict label Aug 16, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Aug 19, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as draft August 19, 2024 07:08
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review August 19, 2024 09:22
Copy link

sonarcloud bot commented Aug 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): Support of IPv6 range for vtep_diagnostic
4 participants