Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen): Fixing the wrong CLI generated for radius-server dynamic-authorizaton #4224

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Jul 17, 2024

Change Summary

Fixing the wrong CLI generated for radius-server dynamic-authorizaton

Related Issue(s)

Fixes #4198

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Fixing the template to implement separate commands for -

radius-server dynamic-authorization port 1700
radius-server dynamic-authorization tls ssl-profile <profile_name>

How to test

Test the molecule scenario and verify in EOS CLI.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4224
# Activate the virtual environment
source test-avd-pr-4224/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@radius_server#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,radius_server --force
# Optional: Install AVD examples
cd test-avd-pr-4224
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Jul 17, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review July 18, 2024 12:03
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners July 18, 2024 12:03
@carlbuchmann carlbuchmann added this to the v4.10.0 milestone Jul 18, 2024
@ClausHolbechArista ClausHolbechArista merged commit 1b64d2e into aristanetworks:devel Jul 22, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong CLI generated for radius-server dynamic-authorizaton
6 participants