[google#4294] --gtest_break_on_failure updated condition to not effec…

…t throw_on_failure. Updated googletest-throw-on-failure-test_.cc to set the throw_on_failure mode.

googletest/src/gtest.cc

@@ -5342,14 +5342,15 @@ void UnitTest::AddTestPartResult(TestPartResult::Type result_type,
       result);
 
   if (result_type != TestPartResult::kSuccess &&
-      result_type != TestPartResult::kSkip &&
-      result_type != TestPartResult::kNonFatalFailure) {
+      result_type != TestPartResult::kSkip/* &&
+      result_type != TestPartResult::kNonFatalFailure*/) {
     // gtest_break_on_failure takes precedence over
     // gtest_throw_on_failure.  This allows a user to set the latter
     // in the code (perhaps in order to use Google Test assertions
     // with another testing framework) and specify the former on the
     // command line for debugging.
-    if (GTEST_FLAG_GET(break_on_failure)) {
+    if (GTEST_FLAG_GET(break_on_failure) &&
+      result_type != TestPartResult::kNonFatalFailure) {
 #if defined(GTEST_OS_WINDOWS) && !defined(GTEST_OS_WINDOWS_PHONE) && \
     !defined(GTEST_OS_WINDOWS_RT)
       // Using DebugBreak on Windows allows gtest to still break into a debugger

googletest/test/googletest-throw-on-failure-test_.cc

@@ -54,6 +54,7 @@ int main(int argc, char** argv) {
   std::set_terminate(&TerminateHandler);
 #endif
   testing::InitGoogleTest(&argc, argv);
+  GTEST_FLAG_SET(throw_on_failure, true);
 
   // We want to ensure that people can use Google Test assertions in
   // other testing frameworks, as long as they initialize Google Test
@@ -63,7 +64,7 @@ int main(int argc, char** argv) {
 
   // In the throw-on-failure mode with exceptions disabled, this
   // assertion will cause the program to exit with a non-zero code.
-  EXPECT_EQ(2, 3);
+    EXPECT_EQ(2, 3);
 
   // When not in the throw-on-failure mode, the control will reach
   // here.