Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xray daemon doesn't appear to recognize EKS Pod Identity #215

Open
bitshop opened this issue Feb 15, 2024 · 1 comment
Open

xray daemon doesn't appear to recognize EKS Pod Identity #215

bitshop opened this issue Feb 15, 2024 · 1 comment

Comments

@bitshop
Copy link

bitshop commented Feb 15, 2024

I believe the image aws-xray-daemon is built on an older SDK version (v1.44.298) which does not support the EKS Pod Identity:
https://aws.amazon.com/blogs/aws/amazon-eks-pod-identity-simplifies-iam-permissions-for-applications-on-amazon-eks-clusters/
https://docs.aws.amazon.com/eks/latest/userguide/pod-id-minimum-sdk.html

Hopefully this is just a mater of update the Go SDK, test, push, update xray container image. I will create a PR for the version change and run tests if time permits and link here.

Is there a chance of getting an updated version pushed out? I'd prefer we not have to build this ourselves. I know another option is ADOT ( https://aws-otel.github.io/ ) but ideally either a) there is guidance suggesting to move to that, or b) we do the full switch to open telemetry from xray.

@wangzlei
Copy link
Contributor

@bitshop Thanks for your info. It is the right way that XRay daemon use the latest AWS SDK for Go dependency.
Please help submit PR, we will review it and schedule a release for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants