You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No longer needed, since now p2p alert messages are logged with log.debug(). "log" level does not reach bisq log because only "info" level and above is printed.
Action: Discussed with Manfred and decided to keep those commits to avoid showing log messages that might scare out the user but in fact are not real problems.
Manfred comment: Http seeds have some privacy issues (peter todd discussed that on old btc mailing list with mike hearn - dns caches so it makes logging on server less effective, with a http seed you can easier log users IPs). We don't nor need http seeds, and prefer to not add a privacy vulnerability without reason for its need.
Why show Wallet.toString() result to users? Manfred: with cmd+j users can see wallet data, Wallet.toString() is used. It's helpful for debugging and techie users who what to see raw wallet data.
Why print keys that have not been shown to users? Manfred: helps for some debugging cases. Some addresses are reserved for the trade, so those are not used in a tx yet but get the flag or a trade purpose (e.g. payout, multisig,….). Also bisq does not allow (yet) in the ui to display more then 1 unused address. Sometimes there is need for getting more unused addresses and then the cmd+j wallet tool can be used to find other unused addresses. thought we should remove that limitation in the receive funds screen and allow users to “create” (display) more unused addresses. there is a GH issue for that.
Risk analysis prevents adding to the wallet (and displaying on the UI) unconfirmed txs that will probably never be confirmed (there is still a chance they get confirmed).
isStandard() check on bitcoinj is in WIP stage and has not been updated as core was updated. These are some checks that are not implemented / wrong:
Non-dust segwit output value should be 294 satoshis (as opposed to 546).
These checks are missing: check only one OP_RETURN output is present, check tx max size, check script sig max size.
To compare bitcoinj and bitcoin core implementations, see bitcoinj's RiskAnalysis and bitcoin core’s validation.cpp AcceptToMemoryPoolWorker and isStandardTx().
This commit excludes OP_RETURN outputs from the MIN_ANALYSIS_NONDUST_OUTPUT check.
The commit is correct and solves part of the problem (the part of the problem that constantly annoys bisq users because BSQ txs use OP_RETURN)
Action: Don't adapt bitcoinj to match bitcoin core. Keep the commit as is.
Count confidence relative to latest block height.
Problem: One transaction can belong to multiple wallets so it would count the depth twice for each block. The problem used to be reproduced on bisq since it uses we use bsq+btc wallets.
Solution: Count depth as current block height - seen block height + 1
I reviewed the changes done by bisq's to bitcoinj.
Here are the conclusions:
Already reviewed
Fixes implemented on https://github.com/bisq-network/bitcoinj/tree/bisq_0.14.7
Still to be reviewed
The text was updated successfully, but these errors were encountered: