Skip to content
This repository has been archived by the owner on Jan 24, 2019. It is now read-only.

OpenID Connect: refreshing the cookie #523

Open
scr4tchy opened this issue Jan 16, 2018 · 1 comment
Open

OpenID Connect: refreshing the cookie #523

scr4tchy opened this issue Jan 16, 2018 · 1 comment

Comments

@scr4tchy
Copy link

Hi,

When #389 was implemented, it seems that the RefreshSessionIfNeeded function's definition is dummy? Why would we not use the refresh token instead and actually refresh the session?

Right now, if cookie-refresh is set, the dummy function is executed, and the code proceeds to ValidateSessionState (saveSession && !revalidated), which throws the ugly removing session. error validating and instantly de-authenticate.

In other words, as of now, if -cookie-expire=24h and -cookie-refresh=1h, instead of having at least 24h worth of session, or infinity if the page is visited every < 24h, we get dope 1h long sessions.

/cc @ericchiang

@JoelSpeed
Copy link
Contributor

I believe #621 solves this issue?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

2 participants