Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rescript-recoil for rescript 11 #40

Open
sprkv5 opened this issue Dec 6, 2023 · 3 comments
Open

Update rescript-recoil for rescript 11 #40

sprkv5 opened this issue Dec 6, 2023 · 3 comments

Comments

@sprkv5
Copy link

sprkv5 commented Dec 6, 2023

Kindly pull in a newer version of recoil package and update rescript package dependency to version 11.

@bloodyowl
Copy link
Owner

PRs are welcome 😊

@sprkv5
Copy link
Author

sprkv5 commented Mar 21, 2024

One of the peer dependencies for this package, is another of your package: rescript-test 6.0.0
Because it defines its peer dependency rescript as "^9.0.0 || ^10.0.0", I'm unable to upgrade rescript version for this package. Should I fork rescript-test as well and update rescript version for it?

@ashton
Copy link

ashton commented Mar 25, 2024

I've opened a PR updating everything that is needed, I've just forced the installation of the rescript-test package, it still working fine in the version 11 and I didn't had any issues running the tests. I did this so the update of this project to version 11 wasn't blocked by opening other PR in other repo, but I can do the same for rescript-test afterwards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants