From 7cdd537b42e7756878cb0dba2d981523d9b6477e Mon Sep 17 00:00:00 2001 From: Davide Bellini Date: Wed, 5 Oct 2016 09:26:52 +0200 Subject: [PATCH] Fixed groups order on API MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Issue: if the request use “?sort=order” returns groups ordered by “order DESC”. This is unexpected. If I would a reversed order I have to use “sort=order&order=desc” --- app/Http/Controllers/Api/ComponentGroupController.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/Http/Controllers/Api/ComponentGroupController.php b/app/Http/Controllers/Api/ComponentGroupController.php index 4804511deb2b..096c4973af17 100644 --- a/app/Http/Controllers/Api/ComponentGroupController.php +++ b/app/Http/Controllers/Api/ComponentGroupController.php @@ -62,7 +62,7 @@ public function getGroups() $groups->search(Binput::except(['sort', 'order', 'per_page'])); if ($sortBy = Binput::get('sort')) { - $direction = Binput::has('order') && Binput::get('order') == 'desc'; + $direction = Binput::get('order', 'asc'); $groups->sort($sortBy, $direction); }